getChildren on Nodes

andimarek · andimarek · commit 799bab09b3d5 · 2015-07-14T03:27:42.000+02:00
diff --git a/src/main/java/graphql/language/Field.java b/src/main/java/graphql/language/Field.java
@@ -48,9 +48,9 @@ public Field(String name, List<Argument> arguments, SelectionSet selectionSet) {
     @Override
     public List<Node> getChildren() {
         List<Node> result = new ArrayList<Node>();
-        result.add(selectionSet);
         result.addAll(arguments);
         result.addAll(directives);
+        result.add(selectionSet);
         return result;
     }
 
diff --git a/src/main/java/graphql/language/FragmentDefinition.java b/src/main/java/graphql/language/FragmentDefinition.java
@@ -62,8 +62,8 @@ public void setSelectionSet(SelectionSet selectionSet) {
     public List<Node> getChildren() {
         List<Node> result = new ArrayList<>();
         result.add(typeCondition);
-        result.add(selectionSet);
         result.addAll(directives);
+        result.add(selectionSet);
         return result;
     }
 
diff --git a/src/main/java/graphql/language/FragmentSpread.java b/src/main/java/graphql/language/FragmentSpread.java
@@ -46,7 +46,9 @@ public boolean equals(Object o) {
 
     @Override
     public List<Node> getChildren() {
-        return new ArrayList<>();
+        List<Node> result = new ArrayList<>();
+        result.addAll(directives);
+        return result;
     }
 
     @Override
diff --git a/src/main/java/graphql/language/InlineFragment.java b/src/main/java/graphql/language/InlineFragment.java
@@ -55,7 +55,11 @@ public void setSelectionSet(SelectionSet selectionSet) {
 
     @Override
     public List<Node> getChildren() {
-        return new ArrayList<>();
+        List<Node> result = new ArrayList<>();
+        result.add(typeCondition);
+        result.addAll(directives);
+        result.add(selectionSet);
+        return result;
     }
 
     @Override
diff --git a/src/main/java/graphql/language/ListType.java b/src/main/java/graphql/language/ListType.java
@@ -25,7 +25,9 @@ public void setType(Type type) {
 
     @Override
     public List<Node> getChildren() {
-        return new ArrayList<>();
+        List<Node> result = new ArrayList<>();
+        result.add(type);
+        return result;
     }
 
     @Override
diff --git a/src/main/java/graphql/language/NonNullType.java b/src/main/java/graphql/language/NonNullType.java
@@ -29,7 +29,9 @@ public void setType(TypeName type) {
 
     @Override
     public List<Node> getChildren() {
-        return new ArrayList<>();
+        List<Node> result = new ArrayList<>();
+        result.add(type);
+        return result;
     }
 
     @Override
diff --git a/src/main/java/graphql/language/ObjectField.java b/src/main/java/graphql/language/ObjectField.java
@@ -24,7 +24,9 @@ public Value getValue() {
 
     @Override
     public List<Node> getChildren() {
-        return new ArrayList<>();
+        List<Node> result = new ArrayList<>();
+        result.add(value);
+        return result;
     }
 
     @Override
diff --git a/src/main/java/graphql/language/ObjectValue.java b/src/main/java/graphql/language/ObjectValue.java
@@ -21,7 +21,9 @@ public List<ObjectField> getObjectFields() {
 
     @Override
     public List<Node> getChildren() {
-        return new ArrayList<>();
+        List<Node> result = new ArrayList<>();
+        result.addAll(objectFields);
+        return result;
     }
 
     @Override
diff --git a/src/main/java/graphql/language/OperationDefinition.java b/src/main/java/graphql/language/OperationDefinition.java
@@ -17,7 +17,7 @@ public enum Operation {
     private List<Directive> directives;
     private SelectionSet selectionSet;
 
-    public OperationDefinition(){
+    public OperationDefinition() {
 
     }
 
@@ -44,7 +44,11 @@ public OperationDefinition(String name, Operation operation, SelectionSet select
 
     @Override
     public List<Node> getChildren() {
-        return new ArrayList<>();
+        List<Node> result = new ArrayList<>();
+        result.addAll(variableDefinitions);
+        result.addAll(directives);
+        result.add(selectionSet);
+        return result;
     }
 
     public String getName() {
diff --git a/src/main/java/graphql/language/SelectionSet.java b/src/main/java/graphql/language/SelectionSet.java
@@ -21,7 +21,9 @@ public SelectionSet(List<Selection> selections) {
 
     @Override
     public List<Node> getChildren() {
-        return new ArrayList<>();
+        List<Node> result = new ArrayList<>();
+        result.addAll(selections);
+        return result;
     }
 
     @Override
diff --git a/src/main/java/graphql/language/StringValue.java b/src/main/java/graphql/language/StringValue.java
@@ -22,7 +22,8 @@ public void setValue(String value) {
 
     @Override
     public List<Node> getChildren() {
-        return new ArrayList<>();
+        List<Node> result = new ArrayList<>();
+        return result;
     }
 
     @Override
diff --git a/src/main/java/graphql/language/VariableDefinition.java b/src/main/java/graphql/language/VariableDefinition.java
@@ -4,7 +4,7 @@
 import java.util.ArrayList;
 import java.util.List;
 
-public class VariableDefinition implements Node{
+public class VariableDefinition implements Node {
 
     private String name;
     private Type type;
@@ -20,7 +20,7 @@ public VariableDefinition(String name, Type type) {
         this.type = type;
     }
 
-    public VariableDefinition(String name, Type type,Value defaultValue) {
+    public VariableDefinition(String name, Type type, Value defaultValue) {
         this.name = name;
         this.type = type;
         this.defaultValue = defaultValue;
@@ -52,7 +52,10 @@ public void setType(Type type) {
 
     @Override
     public List<Node> getChildren() {
-        return new ArrayList<>();
+        List<Node> result = new ArrayList<>();
+        result.add(type);
+        result.add(defaultValue);
+        return result;
     }
 
     @Override

Original file line number	Diff line number	Diff line change
`@@ -62,8 +62,8 @@ public void setSelectionSet(SelectionSet selectionSet) {`
`62`	`62`	`public List<Node> getChildren() {`
`63`	`63`	`List<Node> result = new ArrayList<>();`
`64`	`64`	`result.add(typeCondition);`
`65`		`- result.add(selectionSet);`
`66`	`65`	`result.addAll(directives);`
	`66`	`+ result.add(selectionSet);`
`67`	`67`	`return result;`
`68`	`68`	`}`
`69`	`69`
Original file line number	Diff line number	Diff line change
`@@ -46,7 +46,9 @@ public boolean equals(Object o) {`
`46`	`46`
`47`	`47`	`@Override`
`48`	`48`	`public List<Node> getChildren() {`
`49`		`- return new ArrayList<>();`
	`49`	`+ List<Node> result = new ArrayList<>();`
	`50`	`+ result.addAll(directives);`
	`51`	`+ return result;`
`50`	`52`	`}`
`51`	`53`
`52`	`54`	`@Override`
Original file line number	Diff line number	Diff line change
`@@ -25,7 +25,9 @@ public void setType(Type type) {`
`25`	`25`
`26`	`26`	`@Override`
`27`	`27`	`public List<Node> getChildren() {`
`28`		`- return new ArrayList<>();`
	`28`	`+ List<Node> result = new ArrayList<>();`
	`29`	`+ result.add(type);`
	`30`	`+ return result;`
`29`	`31`	`}`
`30`	`32`
`31`	`33`	`@Override`
Original file line number	Diff line number	Diff line change
`@@ -29,7 +29,9 @@ public void setType(TypeName type) {`
`29`	`29`
`30`	`30`	`@Override`
`31`	`31`	`public List<Node> getChildren() {`
`32`		`- return new ArrayList<>();`
	`32`	`+ List<Node> result = new ArrayList<>();`
	`33`	`+ result.add(type);`
	`34`	`+ return result;`
`33`	`35`	`}`
`34`	`36`
`35`	`37`	`@Override`
Original file line number	Diff line number	Diff line change
`@@ -24,7 +24,9 @@ public Value getValue() {`
`24`	`24`
`25`	`25`	`@Override`
`26`	`26`	`public List<Node> getChildren() {`
`27`		`- return new ArrayList<>();`
	`27`	`+ List<Node> result = new ArrayList<>();`
	`28`	`+ result.add(value);`
	`29`	`+ return result;`
`28`	`30`	`}`
`29`	`31`
`30`	`32`	`@Override`
Original file line number	Diff line number	Diff line change
`@@ -21,7 +21,9 @@ public List<ObjectField> getObjectFields() {`
`21`	`21`
`22`	`22`	`@Override`
`23`	`23`	`public List<Node> getChildren() {`
`24`		`- return new ArrayList<>();`
	`24`	`+ List<Node> result = new ArrayList<>();`
	`25`	`+ result.addAll(objectFields);`
	`26`	`+ return result;`
`25`	`27`	`}`
`26`	`28`
`27`	`29`	`@Override`
Original file line number	Diff line number	Diff line change
`@@ -21,7 +21,9 @@ public SelectionSet(List<Selection> selections) {`
`21`	`21`
`22`	`22`	`@Override`
`23`	`23`	`public List<Node> getChildren() {`
`24`		`- return new ArrayList<>();`
	`24`	`+ List<Node> result = new ArrayList<>();`
	`25`	`+ result.addAll(selections);`
	`26`	`+ return result;`
`25`	`27`	`}`
`26`	`28`
`27`	`29`	`@Override`