Skip to content

Commit fa78abd

Browse files
ranm8ranm8
authored
Harmony/symphony (teambit#2926)
- Many many changes in all areas
1 parent d4117ec commit fa78abd

110 files changed

Lines changed: 2143 additions & 637 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎e2e/fixtures/extensions/extension-add-config/simple-config/simple-config.manifest.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ const { getDeclarationCoreExtension } = require('bit-bin');
22
const PkgExtension = getDeclarationCoreExtension('@teambit/pkg');
33

44
module.exports = {
5-
name: 'simple config',
5+
name: 'simple-config',
66
dependencies: [PkgExtension],
77
provider: async ([pkg]) => {
88
pkg.registerPackageJsonNewProps({ 'my-custom-key': 'my-custom-val' });

‎e2e/harmony/create.e2e.4.ts‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,8 @@ describe('create extension', function () {
2828
helper.command.addComponent('react-create-template');
2929
helper.extensions.addExtensionToWorkspace('my-scope/react-create-template', {});
3030
helper.extensions.addExtensionToWorkspace('@teambit/create', { template: 'react-create-template' });
31+
helper.scopeHelper.linkBitBin();
32+
helper.command.link();
3133
helper.command.create(COMPONENT_NAME);
3234
const compDir = path.join(helper.scopes.localPath, `components/${COMPONENT_NAME}`);
3335
implFilePath = path.join(compDir, `${COMPONENT_NAME}.js`);

‎e2e/harmony/dependency-resolver.e2e.ts‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -100,6 +100,8 @@ describe('dependency-resolver extension', function () {
100100
helper.fixtures.copyFixtureExtensions(EXTENSIONS_BASE_FOLDER);
101101
helper.command.addComponent(EXTENSIONS_BASE_FOLDER);
102102
helper.extensions.addExtensionToVariant('bar/foo', 'my-scope/extension-add-dependencies', config);
103+
helper.scopeHelper.linkBitBin();
104+
helper.command.link();
103105
barFooOutput = helper.command.showComponentParsed('bar/foo');
104106
isTypeOutput = helper.command.showComponentParsed('utils/is-type');
105107
});

‎e2e/harmony/load-extensions.e2e.4.ts‎

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ import {
66
UNABLE_TO_LOAD_EXTENSION_FROM_LIST,
77
} from '../../src/components/utils/load-extensions/constants';
88
import { HARMONY_FEATURE } from '../../src/api/consumer/lib/feature-toggle';
9+
import { CannotLoadExtension } from '../../src/components/utils/load-extensions/exceptions';
910

1011
chai.use(require('chai-fs'));
1112

@@ -47,7 +48,8 @@ describe('load extensions', function () {
4748
});
4849
it('when config set to throw error on failed extensions', () => {
4950
const func = () => helper.command.status();
50-
const error = new Error('error by purpose');
51+
const origError = new Error('error by purpose');
52+
const error = new CannotLoadExtension('non-requireable-extension', origError);
5153
helper.general.expectToThrow(func, error);
5254
});
5355
// TODO: implement
@@ -130,7 +132,8 @@ describe('load extensions', function () {
130132
});
131133
it('when config set to throw error on failed extensions', () => {
132134
const func = () => helper.command.showComponent('affected/comp1');
133-
const error = new Error('error by purpose');
135+
const origError = new Error('error by purpose');
136+
const error = new CannotLoadExtension('non-requireable-extension', origError);
134137
helper.general.expectToThrow(func, error);
135138
});
136139
// TODO: implement

‎e2e/harmony/pkg.e2e.ts‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -87,6 +87,8 @@ describe('pkg extension', function () {
8787
helper.fixtures.copyFixtureExtensions(extensionFolder);
8888
helper.command.addComponent(extensionFolder);
8989
helper.extensions.addExtensionToVariant('bar/foo', 'my-scope/simple-config', config);
90+
helper.scopeHelper.linkBitBin();
91+
helper.command.link();
9092
barFooCapsuleDir = helper.command.createCapsuleHarmony('bar/foo');
9193
isTypeCapsuleDir = helper.command.createCapsuleHarmony('utils/is-type');
9294
});

0 commit comments

Comments
 (0)