Update PULL_REQUEST_TEMPLATE.md (GoogleCloudPlatform#2697)

lesv · web-flow · commit 714b7338df19 · 2020-04-20T22:00:08.000Z
* Move Tests Pass to last, add a comment
* change Fixes line

Fixes #&lt;issue_number_goes_here&gt;

&gt; It's a good idea to open an issue first for discussion.

- [ ] Tests pass (`mvn -P lint clean verify`)?
- [ ] `pom.xml` parent set to latest `shared-configuration`
- [ ] Appropriate changes to README are included in PR
- [ ] API's need to be enabled to test (tell us)
- [ ] Environment Variables need to be set (ask us to set them)
diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md
@@ -1,9 +1,10 @@
-Fixes #<issue_number_goes_here>
+Fixes #issue
 
 > It's a good idea to open an issue first for discussion.
 
-- [ ] Tests pass (`mvn -P lint clean verify`)?
 - [ ] `pom.xml` parent set to latest `shared-configuration`
 - [ ] Appropriate changes to README are included in PR
 - [ ] API's need to be enabled to test (tell us)
 - [ ] Environment Variables need to be set (ask us to set them)
+- [ ] Tests pass (`mvn -P lint clean verify`)
+  * (Note- `Checkstyle` passing is required; `Spotbugs`, `ErrorProne`, `PMD`, etc. `ERROR`'s are advisory only)
