Skip to content

Commit 24a5457

Browse files
antonpirkerantonpirker
authored
Propper naming of requirements files (getsentry#3191)
1 parent 10e33ac commit 24a5457

10 files changed

Lines changed: 11 additions & 11 deletions

‎CONTRIBUTING.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ This will make sure that your commits will have the correct coding style.
6363
```bash
6464
cd sentry-python
6565

66-
pip install -r devenv-requirements.txt
66+
pip install -r requirements-devenv.txt
6767

6868
pip install pre-commit
6969

‎Makefile‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ lint: .venv
5050

5151
apidocs: .venv
5252
@$(VENV_PATH)/bin/pip install --editable .
53-
@$(VENV_PATH)/bin/pip install -U -r ./docs-requirements.txt
53+
@$(VENV_PATH)/bin/pip install -U -r ./requirements-docs.txt
5454
rm -rf docs/_build
5555
@$(VENV_PATH)/bin/sphinx-build -vv -W -b html docs/ docs/_build
5656
.PHONY: apidocs
@@ -61,6 +61,6 @@ apidocs-hotfix: apidocs
6161
.PHONY: apidocs-hotfix
6262

6363
aws-lambda-layer: dist
64-
$(VENV_PATH)/bin/pip install -r aws-lambda-layer-requirements.txt
64+
$(VENV_PATH)/bin/pip install -r requirements-aws-lambda-layer.txt
6565
$(VENV_PATH)/bin/python -m scripts.build_aws_lambda_layer
6666
.PHONY: aws-lambda-layer

aws-lambda-layer-requirements.txt renamed to requirements-aws-lambda-layer.txt

File renamed without changes.

devenv-requirements.txt renamed to requirements-devenv.txt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1-
-r linter-requirements.txt
2-
-r test-requirements.txt
1+
-r requirements-linting.txt
2+
-r requirements-testing.txt
33
mockupdb # required by `pymongo` tests that are enabled by `pymongo` from linter requirements
44
pytest<7.0.0 # https://github.com/pytest-dev/pytest/issues/9621; see tox.ini
55
pytest-asyncio

docs-requirements.txt renamed to requirements-docs.txt

File renamed without changes.

linter-requirements.txt renamed to requirements-linting.txt

File renamed without changes.

test-requirements.txt renamed to requirements-testing.txt

File renamed without changes.

‎scripts/build_aws_lambda_layer.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ def install_python_packages(self):
4444
"pip",
4545
"install",
4646
"-r",
47-
"aws-lambda-layer-requirements.txt",
47+
"requirements-aws-lambda-layer.txt",
4848
"--target",
4949
self.python_site_packages,
5050
],

‎tests/integrations/aws_lambda/client.py‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ def _install_dependencies(base_dir, subprocess_kwargs):
3636
"pip",
3737
"install",
3838
"-r",
39-
"aws-lambda-layer-requirements.txt",
39+
"requirements-aws-lambda-layer.txt",
4040
"--target",
4141
base_dir,
4242
],
@@ -68,7 +68,7 @@ def _install_dependencies(base_dir, subprocess_kwargs):
6868
**subprocess_kwargs,
6969
)
7070
# Install the created Sentry SDK source distribution into the target directory
71-
# Do not install the dependencies of the SDK, because they where installed by aws-lambda-layer-requirements.txt above
71+
# Do not install the dependencies of the SDK, because they where installed by requirements-aws-lambda-layer.txt above
7272
source_distribution_archive = glob.glob(
7373
"{}/*.tar.gz".format(os.path.dirname(base_dir))
7474
)[0]

‎tox.ini‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -252,12 +252,12 @@ envlist =
252252

253253
[testenv]
254254
deps =
255-
# if you change test-requirements.txt and your change is not being reflected
255+
# if you change requirements-testing.txt and your change is not being reflected
256256
# in what's installed by tox (when running tox locally), try running tox
257257
# with the -r flag
258-
-r test-requirements.txt
258+
-r requirements-testing.txt
259259

260-
linters: -r linter-requirements.txt
260+
linters: -r requirements-linting.txt
261261
linters: werkzeug<2.3.0
262262

263263
# === Common ===

0 commit comments

Comments
 (0)