refactor: normalize workspace agent session metadata - #28124
Open
EhabY wants to merge 1 commit into
Open
Conversation
EhabY
force-pushed
the
refactor/normalize-agent-session-metadata
branch
from
August 13, 2026 16:29
099eee9 to
a75121e
Compare
EhabY
marked this pull request as ready for review
August 13, 2026 17:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gives agent session accounting one canonical vocabulary for app names, so later work can report a count per app without the agent and the server disagreeing about what an app is called.
coderd/idemetadata, a leaf package importable from both agent and coderd code, holding the canonical names and their normalization: null bytes stripped, truncated to 64 runes, trimmed, lowercased, hyphens folded to underscores.Connection_Typeenum. It is never used for storage, so a missing alias only costs anunknownlabel.agentssh.Serverkeeps its session counters in a map keyed by normalized name instead of three fixed atomics, dropping entries at zero so idle apps are not reported.extractMagicSessionTypecanonicalizes rather than classifies, so an unrecognized type flows through as itself.Wire behavior is unchanged: the agent still reports the four
session_count_*fields over Agent API 2.10,Collecttranslates only the four canonical names those fields exist for, andTestAgent_Stats_SSH,TestAgent_Stats_Magic, andTestAgent_Stats_ReconnectingPTYstill assert the old fields untouched.Stack
Stats.session_countsprotocol field