docs: fix Helm TLS/ingress value keys in admin/setup - #28087
Draft
nickvigilante wants to merge 1 commit into
Draft
docs: fix Helm TLS/ingress value keys in admin/setup#28087nickvigilante wants to merge 1 commit into
nickvigilante wants to merge 1 commit into
Conversation
The setup guide used chart keys Helm silently ignores: coder.tls.secretName (singular) should be coder.tls.secretNames (a list), and coder.ingress.secretName/wildcardSecretName belong under coder.ingress.tls.{secretName,wildcardSecretName}. Also set coder.ingress.tls.enable so the ingress TLS example actually terminates TLS. Keys verified against helm/coder/values.yaml. Fixes DOCS-643.
> This PR was created with AI assistance (Coder Agents).
Docs previewCheck off each page once it's been reviewed. If a page changes in a later push, its checkbox clears automatically so it gets a fresh look. Pages not yet wired into the docs navigation aren't listed here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fix the Helm values in the TLS setup step of
docs/admin/setup/index.md. The documented keys are silently ignored by the chart, so TLS appears configured but isn't.Changes
coder.tls.secretName(singular) →coder.tls.secretNames(a list). The chart key issecretNames.coder.ingress.secretName/coder.ingress.wildcardSecretName→ nested undercoder.ingress.tls.secretName/coder.ingress.tls.wildcardSecretName, where the chart actually reads them.coder.ingress.tls.enable: trueso the ingress-termination example actually enables TLS.All keys verified against
helm/coder/values.yamlonmain(coder.tls.secretNames,coder.ingress.tls.{enable,secretName,wildcardSecretName}). Surfaced by the runtime drift sweep. The example now parses to the correct chart structure.Linear: DOCS-643