feat(site/src/pages/AgentsPage): make links in chat prompts clickable#27169
Draft
ibetitsmike wants to merge 1 commit into
Draft
feat(site/src/pages/AgentsPage): make links in chat prompts clickable#27169ibetitsmike wants to merge 1 commit into
ibetitsmike wants to merge 1 commit into
Conversation
Collaborator
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. What shall we delve into next? Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
URLs typed into Agents chat prompts rendered as inert text. This PR makes them clickable while keeping prompt text otherwise literal. Assistant responses already autolink via Streamdown + remark-gfm; that behavior is unchanged and now locked in by a story.
Changes
LinkifiedTextwith a pure tokenizer that turnshttp(s)://andwww.URLs in user prompt text into anchors (target="_blank",rel="noopener noreferrer", response-matching styling,urlTransformsupport for workspace proxy rewrites). Trailing punctuation and unbalanced closing parens are excluded from the link; scheme-less bare domains are intentionally not linked; only http/https hrefs can be produced. Markdown syntax in prompts stays literal.UserMessageContenttext paths (inline content blocks and the plain-string fallback) throughLinkifiedText, preserving file-reference chip interleaving; threadurlTransformfromConversationTimeline.Validation
make pre-commit, targeted vitest (12/12), storybook vitest forConversationTimeline.stories.tsx(56/56).www., trailing punctuation, literal[md](url), script-tag text) render and click through correctly; assistant response links verified through the real UI with DOM attribute checks and click-through.