refactor(aibridge/intercept): move actor header injection into client-header middleware#26543
Draft
ssncferreira wants to merge 1 commit into
Draft
refactor(aibridge/intercept): move actor header injection into client-header middleware#26543ssncferreira wants to merge 1 commit into
ssncferreira wants to merge 1 commit into
Conversation
This comment has been minimized.
This comment has been minimized.
…-header middleware Move actor header injection from per-request SDK options in 6 blocking/streaming handlers into the client-header middleware in the 3 service builders. This eliminates duplicated logic and resolves all ssncferreira TODO comments about actor headers. Changes: - Add SetActorHeaders to inject actor headers directly into http.Header - Inject actor headers in the middleware closures of newResponsesService, newMessagesService, and newCompletionsService - Remove actor header SDK option injection from all 6 blocking/streaming handlers - Remove actor header preservation from BuildUpstreamHeaders (no longer needed since headers are set after BuildUpstreamHeaders in the middleware) - Add unit tests for SetActorHeaders - Update BuildUpstreamHeaders test to reflect the new behavior
c9c0e69 to
d0bd79f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move actor header injection from per-request SDK options in the 6 blocking/streaming handlers into the client-header middleware in the 3 service builders (
newResponsesService,newMessagesService,newCompletionsService). This eliminates duplicated logic and resolves allssncferreiraTODO comments about actor headers.Previously, each blocking and streaming handler in
responses,messages, andchatcompletionsindependently checked for an actor in the request context and injected actor headers as SDK request options. The client-header middleware then had to preserve these headers from the SDK-built request. Now, the middleware injects actor headers directly after building upstream headers, using the request context that the SDK propagates from the caller.SetActorHeadersto inject actor headers directly intohttp.HeaderBuildUpstreamHeaders(no longer needed)SetActorHeaders; updateBuildUpstreamHeaderstests