fix(aibridge): increase circuit breaker test timeout to prevent flake#26519
Open
ssncferreira wants to merge 1 commit into
Open
fix(aibridge): increase circuit breaker test timeout to prevent flake#26519ssncferreira wants to merge 1 commit into
ssncferreira wants to merge 1 commit into
Conversation
ee591f0 to
9bf9ea7
Compare
9bf9ea7 to
4ac65a6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TestCircuitBreaker_FullRecoveryCycle/OpenAIflaked once on macOS CI. The most likely cause is that the circuit breakerTimeout(open-to-half-open transition) was too short relative to the time between test phases. On a slow runner, the breaker could transition to half-open before the test verified it was still open, so the request went through as a half-open probe instead of being rejected.Increases
Timeouttotestutil.IntervalSlow(1 second) across all circuit breaker integration tests.Note: Ideally, these tests would use a mock clock for deterministic timing, but https://github.com/sony/gobreaker (the library used for circuit breaker logic) uses real time internally and doesn't expose a clock interface.
Closes https://linear.app/codercom/issue/AIGOV-438