chore: refactor NATS pubsub to use MsgQueue#26197
Draft
spikecurtis wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the existing MsgQueue from the original PGPubsub instead of the 2-channel solution originally built here.
Renames
natsSubtogroupSub, since conceptually, a "NATS Subscription" already refers to the underlying subscription on the NATS server.This PR also simplifies the closing of the PubSub to just close each
localSub. When the lastlocalSubfor an event is closed, it unsubscribes and remove thegroupSub. This ensures we go through the same code paths closing normally and at end of day.