From 900df1653a31a3ab02b75a3a2ec1d9898a865ef8 Mon Sep 17 00:00:00 2001 From: Tracy Johnson Date: Wed, 3 Jun 2026 03:37:49 +0000 Subject: [PATCH 1/3] fix(site): fix provider link on models page pointing to stale path The "Connect a provider" link on /agents/settings/models was pointing to /agents/settings/providers instead of /ai/settings. Update the link to point to the canonical provider configuration page. --- .../AgentsPage/AgentSettingsProvidersPage.tsx | 101 ------------------ .../ModelsSection.stories.tsx | 2 +- .../ChatModelAdminPanel/ModelsSection.tsx | 2 +- site/src/router.tsx | 8 +- 4 files changed, 6 insertions(+), 107 deletions(-) delete mode 100644 site/src/pages/AgentsPage/AgentSettingsProvidersPage.tsx diff --git a/site/src/pages/AgentsPage/AgentSettingsProvidersPage.tsx b/site/src/pages/AgentsPage/AgentSettingsProvidersPage.tsx deleted file mode 100644 index 7fc3f3396c15a..0000000000000 --- a/site/src/pages/AgentsPage/AgentSettingsProvidersPage.tsx +++ /dev/null @@ -1,101 +0,0 @@ -import type { FC } from "react"; -import { useMutation, useQuery, useQueryClient } from "react-query"; -import { - chatModelConfigs, - chatModels, - chatProviderConfigs, - createChatModelConfig, - createChatProviderConfig, - deleteChatModelConfig, - deleteChatProviderConfig, - updateChatModelConfig, - updateChatProviderConfig, -} from "#/api/queries/chats"; -import { useAuthenticated } from "#/hooks/useAuthenticated"; -import { RequirePermission } from "#/modules/permissions/RequirePermission"; -import { ChatModelAdminPanel } from "./components/ChatModelAdminPanel/ChatModelAdminPanel"; - -const AgentSettingsProvidersPage: FC = () => { - const { permissions } = useAuthenticated(); - - const queryClient = useQueryClient(); - - // Queries. - const providerConfigsQuery = useQuery({ - ...chatProviderConfigs(), - enabled: permissions.editDeploymentConfig, - }); - const modelConfigsQuery = useQuery(chatModelConfigs()); - const modelCatalogQuery = useQuery(chatModels()); - - // Mutations. - const createProviderMutation = useMutation( - createChatProviderConfig(queryClient), - ); - const updateProviderMutation = useMutation( - updateChatProviderConfig(queryClient), - ); - const deleteProviderMutation = useMutation( - deleteChatProviderConfig(queryClient), - ); - const createModelMutation = useMutation(createChatModelConfig(queryClient)); - const updateModelMutation = useMutation(updateChatModelConfig(queryClient)); - const deleteModelMutation = useMutation(deleteChatModelConfig(queryClient)); - - return ( - - createProviderMutation.mutateAsync(req)} - onUpdateProvider={(providerConfigId, req) => - updateProviderMutation.mutateAsync({ providerConfigId, req }) - } - onDeleteProvider={(id) => deleteProviderMutation.mutateAsync(id)} - isProviderMutationPending={ - createProviderMutation.isPending || - updateProviderMutation.isPending || - deleteProviderMutation.isPending - } - providerMutationError={ - createProviderMutation.error ?? - updateProviderMutation.error ?? - deleteProviderMutation.error - } - onCreateModel={(req) => createModelMutation.mutateAsync(req)} - onUpdateModel={(modelConfigId, req) => - updateModelMutation.mutateAsync({ modelConfigId, req }) - } - onDeleteModel={(id) => deleteModelMutation.mutateAsync(id)} - isCreatingModel={createModelMutation.isPending} - isUpdatingModel={updateModelMutation.isPending} - isDeletingModel={deleteModelMutation.isPending} - modelMutationError={ - createModelMutation.error ?? - updateModelMutation.error ?? - deleteModelMutation.error - } - /> - - ); -}; - -export default AgentSettingsProvidersPage; diff --git a/site/src/pages/AgentsPage/components/ChatModelAdminPanel/ModelsSection.stories.tsx b/site/src/pages/AgentsPage/components/ChatModelAdminPanel/ModelsSection.stories.tsx index cf74c1caaf6fc..7003d3d145ed6 100644 --- a/site/src/pages/AgentsPage/components/ChatModelAdminPanel/ModelsSection.stories.tsx +++ b/site/src/pages/AgentsPage/components/ChatModelAdminPanel/ModelsSection.stories.tsx @@ -164,7 +164,7 @@ export const LinksToProvidersFromEmptyState: Story = { await expect(canvas.getByText("No models configured yet.")).toBeVisible(); await expect(providerLink).toBeVisible(); - expect(providerLink).toHaveAttribute("href", "/agents/settings/providers"); + expect(providerLink).toHaveAttribute("href", "/ai/settings"); }, }; diff --git a/site/src/pages/AgentsPage/components/ChatModelAdminPanel/ModelsSection.tsx b/site/src/pages/AgentsPage/components/ChatModelAdminPanel/ModelsSection.tsx index 0cc2a554d5174..f4738bc9f334c 100644 --- a/site/src/pages/AgentsPage/components/ChatModelAdminPanel/ModelsSection.tsx +++ b/site/src/pages/AgentsPage/components/ChatModelAdminPanel/ModelsSection.tsx @@ -311,7 +311,7 @@ export const ModelsSection: FC = ({

Connect a{" "} provider diff --git a/site/src/router.tsx b/site/src/router.tsx index 6ac39cec75c5d..1a6da237c6600 100644 --- a/site/src/router.tsx +++ b/site/src/router.tsx @@ -384,9 +384,6 @@ const AgentSettingsUserAgentsPage = lazy( const AgentSettingsPersonalSkillsPage = lazy( () => import("./pages/AgentsPage/AgentSettingsPersonalSkillsPage"), ); -const AgentSettingsProvidersPage = lazy( - () => import("./pages/AgentsPage/AgentSettingsProvidersPage"), -); const AgentSettingsAPIKeysPage = lazy( () => import("./pages/AgentsPage/AgentSettingsAPIKeysPage"), ); @@ -791,7 +788,10 @@ export const router = createBrowserRouter( } /> } /> } /> - } /> + } + /> } /> Date: Wed, 3 Jun 2026 05:47:51 +0000 Subject: [PATCH 2/3] fix: remove providers from ADMIN_SETTINGS_SECTIONS --- site/src/pages/AgentsPage/components/ChatsSidebar/sidebarView.ts | 1 - 1 file changed, 1 deletion(-) diff --git a/site/src/pages/AgentsPage/components/ChatsSidebar/sidebarView.ts b/site/src/pages/AgentsPage/components/ChatsSidebar/sidebarView.ts index 7da6fd0258595..dd06437b3c280 100644 --- a/site/src/pages/AgentsPage/components/ChatsSidebar/sidebarView.ts +++ b/site/src/pages/AgentsPage/components/ChatsSidebar/sidebarView.ts @@ -7,7 +7,6 @@ type SidebarView = const ADMIN_SETTINGS_SECTIONS = new Set([ "agents", "templates", - "providers", "models", "mcp-servers", "spend", From bbc453cf26d1b5a1f31ed3ddb1fdf2b37de010fc Mon Sep 17 00:00:00 2001 From: Jaayden Halko Date: Wed, 3 Jun 2026 05:50:58 +0000 Subject: [PATCH 3/3] fix: remove test --- .../AgentsPage/components/ChatsSidebar/sidebarView.test.ts | 7 ------- 1 file changed, 7 deletions(-) diff --git a/site/src/pages/AgentsPage/components/ChatsSidebar/sidebarView.test.ts b/site/src/pages/AgentsPage/components/ChatsSidebar/sidebarView.test.ts index 3bfc68fcae599..3e963414490e0 100644 --- a/site/src/pages/AgentsPage/components/ChatsSidebar/sidebarView.test.ts +++ b/site/src/pages/AgentsPage/components/ChatsSidebar/sidebarView.test.ts @@ -53,13 +53,6 @@ describe("sidebarViewFromPath", () => { }); }); - it("returns the providers admin settings section", () => { - expect(sidebarViewFromPath("/agents/settings/providers")).toEqual({ - panel: "settings-admin", - section: "providers", - }); - }); - it("normalizes the admin index route to an undefined section", () => { expect(sidebarViewFromPath("/agents/settings/admin")).toEqual({ panel: "settings-admin",