Skip to content

fix(site/src/pages/AgentsPage): avoid skills popup flash#25661

Merged
ibetitsmike merged 2 commits into
mainfrom
mike/skills-popup-05jb
May 25, 2026
Merged

fix(site/src/pages/AgentsPage): avoid skills popup flash#25661
ibetitsmike merged 2 commits into
mainfrom
mike/skills-popup-05jb

Conversation

@ibetitsmike

@ibetitsmike ibetitsmike commented May 25, 2026

Copy link
Copy Markdown
Collaborator

When removing the / personal skill trigger, the popover content stayed mounted during its close transition and briefly rendered the empty skills state at the viewport origin.

This keeps the menu content mounted for stable Radix positioning, preserves the last open menu state during the close transition, and adds a Storybook regression for the backspace path.

Mux is creating this PR on behalf of Mike.

@ibetitsmike

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Swish!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@ibetitsmike ibetitsmike marked this pull request as ready for review May 25, 2026 19:44
@coder-tasks

coder-tasks Bot commented May 25, 2026

Copy link
Copy Markdown
Contributor

Documentation Check

No documentation changes are needed for this PR.

This is a pure frontend rendering fix that:

  • Prevents a visual flash during menu close transitions
  • Preserves menu positioning state during animations
  • Adds a Storybook regression test

No user-facing features, API changes, or configuration updates require documentation.


Automated review via Coder Agents

@ibetitsmike ibetitsmike merged commit 84240da into main May 25, 2026
32 checks passed
@ibetitsmike ibetitsmike deleted the mike/skills-popup-05jb branch May 25, 2026 19:58
@github-actions github-actions Bot locked and limited conversation to collaborators May 25, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants