refactor(site): replace !! with Boolean() for boolean coercion#24180
Merged
DanielleMaywood merged 2 commits intomainfrom Apr 9, 2026
Merged
refactor(site): replace !! with Boolean() for boolean coercion#24180DanielleMaywood merged 2 commits intomainfrom
!! with Boolean() for boolean coercion#24180DanielleMaywood merged 2 commits intomainfrom
Conversation
johnstcn
approved these changes
Apr 9, 2026
Member
johnstcn
left a comment
There was a problem hiding this comment.
I'm fine with this, but could you explain why this is better?
Contributor
Author
|
@johnstcn It's more explicit about what it's doing (that we're casting to a boolean) instead of using javascript double invert logic If @aslilac is reviewing a PR and spots them she always calls out to switch over to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces all
!!<variable>double-negation patterns in the frontend withBoolean(<variable>)for explicit boolean coercion.Two special cases where
!!was serving as a type-narrowing mechanism (TypeScript's aliased conditional narrowing):GitPanel.tsx—!!remoteDiffStats && remoteDiffStats.additionsreplaced withremoteDiffStats != null && ...to preserve narrowing.NotificationsPage.tsx—const ready = !!(...data && ...data && ...data)replaced with explicit!= nullchecks to preserve aliased narrowing through thereadyvariable.TaskPage.tsx—.filter((a) => !!a)replaced with.filter(Boolean)which is idiomatic and type-safe in TypeScript 5.5+.25 files changed, zero
!!remaining insite/src.