🤖 fix(site): tidy storybook coverage and copy on the AI settings entry points

jakehwll · jakehwll · commit 76cc7626ea66 · 2026-05-14T13:56:06.000Z
Smaller review-pass cleanup that didn't fit the security / a11y
buckets:

* NavbarView.stories: pass `canViewAISettings` to every story that
  enumerates the `canView*` flags, including the admin default,
  auditor, org admin, single-org OSS admin, member, agents-only
  member, and the support-link stories. The new flag was missing
  from these stories, so the AI Settings link never appeared in
  Chromatic / interaction snapshots.

* DeploymentDropdown: restore the braces around the early `return
  null;` after the multi-line condition. The braces were dropped
  accidentally when `canViewAISettings` was inserted into the
  guard. This is the only braceless multi-line `if` in the file
  and clashes with the local style.

* Page copy: the providers list and the add-provider page both
  said "OpenAI, Anthropic, or Google", but the type selector only
  offers OpenAI, Anthropic, and Bedrock. Swap "Google" for "Amazon
  Bedrock" so the copy matches the form.
diff --git a/site/src/modules/dashboard/Navbar/DeploymentDropdown.tsx b/site/src/modules/dashboard/Navbar/DeploymentDropdown.tsx
@@ -37,8 +37,9 @@ export const DeploymentDropdown: FC<DeploymentDropdownProps> = ({
 		!canViewAIBridge &&
 		!canViewAISettings &&
 		!canViewHealth
-	)
+	) {
 		return null;
+	}
 
 	return (
 		<DropdownMenu>
diff --git a/site/src/modules/dashboard/Navbar/NavbarView.stories.tsx b/site/src/modules/dashboard/Navbar/NavbarView.stories.tsx
@@ -34,6 +34,7 @@ const meta: Meta<typeof NavbarView> = {
 		canViewDeployment: true,
 		canViewHealth: true,
 		canViewOrganizations: true,
+		canViewAISettings: true,
 		canCreateChat: true,
 		supportLinks: [],
 	},
@@ -59,6 +60,7 @@ export const ForAuditor: Story = {
 		canViewDeployment: false,
 		canViewHealth: false,
 		canViewOrganizations: false,
+		canViewAISettings: false,
 	},
 	play: async ({ canvasElement }) => {
 		const canvas = within(canvasElement);
@@ -75,6 +77,7 @@ export const ForOrgAdmin: Story = {
 		canViewDeployment: false,
 		canViewHealth: false,
 		canViewOrganizations: true,
+		canViewAISettings: false,
 	},
 	play: async ({ canvasElement }) => {
 		const canvas = within(canvasElement);
@@ -90,6 +93,7 @@ export const ForSingleOrgOSSAdmin: Story = {
 		canViewOrganizations: false,
 		canViewConnectionLog: false,
 		canViewAIBridge: false,
+		canViewAISettings: false,
 	},
 	play: async ({ canvasElement }) => {
 		const canvas = within(canvasElement);
@@ -106,6 +110,7 @@ export const ForMember: Story = {
 		canViewDeployment: false,
 		canViewHealth: false,
 		canViewOrganizations: false,
+		canViewAISettings: false,
 		canCreateChat: false,
 	},
 };
@@ -117,6 +122,7 @@ export const ForMemberWithAgentsAccess: Story = {
 		canViewDeployment: false,
 		canViewHealth: false,
 		canViewOrganizations: false,
+		canViewAISettings: false,
 		canCreateChat: true,
 	},
 };
@@ -139,6 +145,7 @@ export const SupportLinks: Story = {
 		canViewDeployment: false,
 		canViewHealth: false,
 		canViewOrganizations: false,
+		canViewAISettings: false,
 		supportLinks: [
 			{
 				name: "This is a bug",
@@ -179,6 +186,7 @@ export const DefaultSupportLinks: Story = {
 		canViewDeployment: false,
 		canViewHealth: false,
 		canViewOrganizations: false,
+		canViewAISettings: false,
 		supportLinks: [
 			{ icon: "docs", name: "Documentation", target: "" },
 			{ icon: "bug", name: "Report a bug", target: "" },
diff --git a/site/src/pages/AISettingsPage/ProvidersPage/AddProviderPage/AddProviderPageView.tsx b/site/src/pages/AISettingsPage/ProvidersPage/AddProviderPage/AddProviderPageView.tsx
@@ -32,9 +32,9 @@ const AddProviderPageView: React.FC = () => {
 				<PageHeader className="pt-6 pb-0">
 					<PageHeaderTitle>Add a provider</PageHeaderTitle>
 					<PageHeaderSubtitle>
-						Connect third-party LLM services like OpenAI, Anthropic, or Google.
-						Each provider supplies models that users can select for their
-						conversations.
+						Connect third-party LLM services like OpenAI, Anthropic, or Amazon
+						Bedrock. Each provider supplies models that users can select for
+						their conversations.
 					</PageHeaderSubtitle>
 				</PageHeader>
 				<div className="border border-solid p-6 rounded-lg">
diff --git a/site/src/pages/AISettingsPage/ProvidersPage/ProvidersPageView.tsx b/site/src/pages/AISettingsPage/ProvidersPage/ProvidersPageView.tsx
@@ -46,8 +46,8 @@ const ProvidersPageView: React.FC<ProvidersPageViewProps> = ({
 			>
 				<PageHeaderTitle>Providers</PageHeaderTitle>
 				<PageHeaderSubtitle>
-					Connect third-party LLM services like OpenAI, Anthropic, or Google.
-					Each provider supplies models that users can select for their
+					Connect third-party LLM services like OpenAI, Anthropic, or Amazon
+					Bedrock. Each provider supplies models that users can select for their
 					conversations.
 				</PageHeaderSubtitle>
 			</PageHeader>
