fix(coderd): isolate OIDC fake IDP in parallel subtests (#26075)

ibetitsmike · web-flow · commit 242c4d791b97 · 2026-06-04T23:03:02.000+02:00
diff --git a/coderd/userauth_test.go b/coderd/userauth_test.go
@@ -1770,13 +1770,6 @@ func TestUserOIDC(t *testing.T) {
 	t.Run("OIDCEmailFallbackBlockedByExistingLink", func(t *testing.T) {
 		t.Parallel()
 
-		fake := oidctest.NewFakeIDP(t,
-			oidctest.WithRefresh(func(_ string) error {
-				return xerrors.New("refreshing token should never occur")
-			}),
-			oidctest.WithServing(),
-		)
-
 		for _, tc := range []struct {
 			name         string
 			allowSignups bool
@@ -1788,6 +1781,12 @@ func TestUserOIDC(t *testing.T) {
 			t.Run(tc.name, func(t *testing.T) {
 				t.Parallel()
 
+				fake := oidctest.NewFakeIDP(t,
+					oidctest.WithRefresh(func(_ string) error {
+						return xerrors.New("refreshing token should never occur")
+					}),
+					oidctest.WithServing(),
+				)
 				cfg := fake.OIDCConfig(t, nil, func(cfg *coderd.OIDCConfig) {
 					cfg.AllowSignups = tc.allowSignups
 				})
