[Bug]: proxy by nginx websocket origin check error #6161

Activity

1. 502647092

   added

   bugSomething isn't workingSomething isn't working

   triageThis issue needs to be triaged by a maintainerThis issue needs to be triaged by a maintainer

   on Apr 23, 2023
2. 502647092 commented on Apr 23, 2023

   

   502647092

   on Apr 23, 2023

   Author

   More actions

   I fix it by modify nginx config
   Origin Config

               proxy_set_header      Host                $host;
               proxy_set_header      X-Real-IP           $remote_addr;
               proxy_set_header      X-Forwarded-For     $proxy_add_x_forwarded_for;
               proxy_set_header      X-Forwarded-Host    $host:$server_port;
               proxy_set_header      X-Forwarded-Proto   $scheme;

   Modified

               proxy_set_header      Host                $host;
               proxy_set_header      X-Real-IP           $remote_addr;
               proxy_set_header      X-Forwarded-For     $proxy_add_x_forwarded_for;
               proxy_set_header      X-Forwarded-Host    $host;    <=== remove port
               proxy_set_header      X-Forwarded-Proto   $scheme;

   👍React with 👍1Reacted by ywzhaiqi
3. 502647092

   closed this as completedon Apr 23, 2023
4. 502647092

   changed the title [-][Bug]: proxy by nginx origin check error[/-] [+][Bug]: proxy by nginx websocket origin check error[/+] on Apr 23, 2023
5. code-asher commented on Apr 24, 2023

   

   code-asher

   on Apr 24, 2023

   Member

   More actions

   Oh interesting! We should make special exceptions for 443 and 80. #6166
6. mashroomxl commented on Nov 12, 2023

   

   mashroomxl

   on Nov 12, 2023

   Last edited by mashroomxl

   More actions

   try nginx config as follows:

   location ~ ${your frontend url pattern} {
       # add it if your url is dynamic
       resolver {your DNS server}
       
       # trick here, consult here for Nginx official doc
       proxy_http_version 1.1;
       proxy_set_header Upgrade $http_upgrade;
       proxy_set_header Connection upgrade;
       # trick here, if absent, the server will block the websocket request if the origin is NOT equal to the host
       proxy_set_header Origin http://${your backend host}/;
       proxy_set_header X-Forwarded-Host $host;
       proxy_set_header X-Real-IP $remote_addr;
       proxy_set_header X-Forwarded-For $proxy_add_x_forwarded_for;
       proxy_set_header X-Forwarded-Proto $scheme;
       
       proxy_set_header Accept-Encoding gzip;
       proxy_cookie_domain ${your backend host} ${your frontend host};
       
       proxy_pass ${your backend url pattern};
   }

   config above working for me. my scene：

   • code-server: 4.18.0, running in an container of Kubernetes
   • nginx:1.9.7, running in an container of another Kubernetes.