You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
OS Version: Docker on RH7 running Debian Buster (php-apache base image)
Description
Had a case where a user was unable to login to code server...
After a lot of testing and trial and error I discovered that if the user defined password (generated using a password generator, see below) contains a '=' character, code server will not allow the user to login.
This only seems to effect v2 it looks like it works fine with v1
Steps to Reproduce
Start code-server with a user defined password containing '=' signs...
Now try to login...
If an invalid password is typed you get an error "Invalid password"
But if you try the correct password you just get the login screen again without an error.
That is code-server knows it has the right password, but it fails to authenticate the user.
No error is generated in the normal output log on the correct, but looping, password.
It works fine if you do this with a password containing no '=' signs in it
It also works fine for code-server v1
ASIDE: The password generator used is a XKCD style generator with 4 random words separated by some special character.
# four random words, XKCD style, with separator symbol
sep=$( shuf -en1 @ ^ \* - = _ + :\|\~. , / );
egrep '^[[:alpha:]]{3,8}$' /usr/share/dict/words | shuf -n 4 | paste -d"$sep" -s
Activity
antofthy commentedon Oct 29, 2019
confirmed fixed in latest release v2.1655-vsc1.39.2