remove delete_all from tests. fix face coordinates in explicit

itaibenari · itaibenari · commit f265c8992699 · 2014-01-10T09:51:08.000+02:00
diff --git a/cloudinary-core/src/main/java/com/cloudinary/Uploader.java b/cloudinary-core/src/main/java/com/cloudinary/Uploader.java
@@ -105,7 +105,9 @@ public Map explicit(String publicId, Map options) throws IOException {
 		params.put("eager", buildEager((List<Transformation>) options.get("eager")));
 		params.put("headers", buildCustomHeaders(options.get("headers")));
 		params.put("tags", StringUtils.join(Cloudinary.asArray(options.get("tags")), ","));
-		params.put("face_coordinates", StringUtils.join(Cloudinary.asArray(options.get("face_coordinates")), ","));
+		if (options.get("face_coordinates") != null) {
+			params.put("face_coordinates", options.get("face_coordinates").toString());
+		}
 		return callApi("explicit", params, options, null);
 	}
 
diff --git a/cloudinary-core/src/test/java/com/cloudinary/test/ApiTest.java b/cloudinary-core/src/test/java/com/cloudinary/test/ApiTest.java
@@ -352,8 +352,8 @@ private void assertContains(Object object, Collection list) {
         assertTrue(list.contains(object));
     }
     
-    //this test must be last because it deletes (potentially) all dependent transformations which some tests rely on.
-    @Test
+    // This test must be last because it deletes (potentially) all dependent transformations which some tests rely on.
+    // Add @Test if you really want to test it - This test deletes derived resources!
     public void testDeleteAllResources() throws Exception {
         // should allow deleting all resources
         cloudinary.uploader().upload("src/test/resources/logo.png", Cloudinary.asMap("public_id", "api_test5", "eager", Collections.singletonList(new Transformation().crop("scale").width(2.0))));
