Add direction support to resource listing.

itaibenari · itaibenari · commit 98f2402e4859 · 2014-01-17T14:32:19.000+02:00
diff --git a/cloudinary-core/src/main/java/com/cloudinary/Api.java b/cloudinary-core/src/main/java/com/cloudinary/Api.java
@@ -121,13 +121,13 @@ public Map resources(Map options) throws Exception {
         uri.add(resourceType);
         if (type != null)
             uri.add(type);
-        return callApi(HttpMethod.GET, uri, only(options, "next_cursor", "max_results", "prefix", "tags", "context"), options);
+        return callApi(HttpMethod.GET, uri, only(options, "next_cursor", "direction", "max_results", "prefix", "tags", "context"), options);
     }
 
     public Map resourcesByTag(String tag, Map options) throws Exception {
         if (options == null) options = Cloudinary.emptyMap();
         String resourceType = Cloudinary.asString(options.get("resource_type"), "image");
-        return callApi(HttpMethod.GET, Arrays.asList("resources", resourceType, "tags", tag), only(options, "next_cursor", "max_results", "tags", "context"), options);
+        return callApi(HttpMethod.GET, Arrays.asList("resources", resourceType, "tags", tag), only(options, "next_cursor", "direction", "max_results", "tags", "context"), options);
     }
     
     public Map resourcesByIds(Iterable<String> publicIds, Map options) throws Exception {
diff --git a/cloudinary-core/src/test/java/com/cloudinary/test/ApiTest.java b/cloudinary-core/src/test/java/com/cloudinary/test/ApiTest.java
@@ -137,6 +137,17 @@ public void test05ResourcesByPrefix() throws Exception {
         assertTrue(found);
     }
     
+    @Test
+    public void testResourcesListingDirection() throws Exception {
+        // should allow listing resources in both directions
+        Map result = api.resources(Cloudinary.asMap("type", "upload", "prefix", "api_test", "direction", "asc"));
+        List<Map> resources = (List<Map>) result.get("resources");
+        result = api.resources(Cloudinary.asMap("type", "upload", "prefix", "api_test", "direction", -1));
+        List<Map> resourcesDesc = (List<Map>) result.get("resources");
+        Collections.reverse(resources);
+        assertEquals(resources, resourcesDesc);
+    }
+    
     @Test
     public void testResourcesByPublicIds() throws Exception {
         // should allow listing resources by public ids
diff --git a/cloudinary-core/src/test/java/com/cloudinary/test/CloudinaryTest.java b/cloudinary-core/src/test/java/com/cloudinary/test/CloudinaryTest.java
@@ -433,6 +433,11 @@ public void testSignedUrl() {
     			generate("image.jpg");
     	assertEquals(expected, actual);
     }
+    
+    public void testUtils() {
+    	assertEquals(Cloudinary.asBoolean(true, null), true);
+    	assertEquals(Cloudinary.asBoolean(false, null), false);
+    }
 	
 	public static Map<String, String> getUrlParameters(URI uri) throws UnsupportedEncodingException {
 		Map<String, String> params = new HashMap<String, String>();

Original file line number	Diff line number	Diff line change
`@@ -121,13 +121,13 @@ public Map resources(Map options) throws Exception {`
`121`	`121`	`uri.add(resourceType);`
`122`	`122`	`if (type != null)`
`123`	`123`	`uri.add(type);`
`124`		`- return callApi(HttpMethod.GET, uri, only(options, "next_cursor", "max_results", "prefix", "tags", "context"), options);`
	`124`	`+ return callApi(HttpMethod.GET, uri, only(options, "next_cursor", "direction", "max_results", "prefix", "tags", "context"), options);`
`125`	`125`	`}`
`126`	`126`
`127`	`127`	`public Map resourcesByTag(String tag, Map options) throws Exception {`
`128`	`128`	`if (options == null) options = Cloudinary.emptyMap();`
`129`	`129`	`String resourceType = Cloudinary.asString(options.get("resource_type"), "image");`
`130`		`- return callApi(HttpMethod.GET, Arrays.asList("resources", resourceType, "tags", tag), only(options, "next_cursor", "max_results", "tags", "context"), options);`
	`130`	`+ return callApi(HttpMethod.GET, Arrays.asList("resources", resourceType, "tags", tag), only(options, "next_cursor", "direction", "max_results", "tags", "context"), options);`
`131`	`131`	`}`
`132`	`132`
`133`	`133`	`public Map resourcesByIds(Iterable<String> publicIds, Map options) throws Exception {`