Skip to content

Commit 6c01817

Browse files
Updated pom.xml to handle custom src and test-src directories
Updated .gitignore to ignore Eclipse specific stuff Fixed bug for param with multiple values in Api.callApi.
1 parent 737439b commit 6c01817

3 files changed

Lines changed: 12 additions & 5 deletions

File tree

.gitignore

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,6 @@
11
bin
22
lib
33
target
4+
.classpath
5+
.project
6+
.settings

pom.xml

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,9 @@
44
<artifactId>cloudinary_java</artifactId>
55
<version>0.1-SNAPSHOT</version>
66
<name>Cloudinary Java Client Library</name>
7+
<properties>
8+
<project.build.sourceEncoding>utf-8</project.build.sourceEncoding>
9+
</properties>
710
<dependencies>
811
<dependency>
912
<groupId>commons-lang</groupId>
@@ -51,4 +54,8 @@
5154
<version>4.10</version>
5255
</dependency>
5356
</dependencies>
57+
<build>
58+
<sourceDirectory>src</sourceDirectory>
59+
<testSourceDirectory>tests</testSourceDirectory>
60+
</build>
5461
</project>

src/com/cloudinary/Api.java

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,6 @@
1212
import org.apache.commons.codec.binary.Base64;
1313
import org.apache.commons.lang.StringUtils;
1414
import org.apache.http.HttpResponse;
15-
import org.apache.http.auth.AuthScope;
16-
import org.apache.http.auth.UsernamePasswordCredentials;
1715
import org.apache.http.client.methods.HttpDelete;
1816
import org.apache.http.client.methods.HttpGet;
1917
import org.apache.http.client.methods.HttpPost;
@@ -212,9 +210,8 @@ protected Map callApi(HttpMethod method, Iterable<String> uri, Map<String, ? ext
212210
URIBuilder apiUrlBuilder = new URIBuilder(apiUrl);
213211
for (Map.Entry<String, ? extends Object> param : params.entrySet()) {
214212
if (param.getValue() instanceof Iterable) {
215-
for (String single : (Iterable<String>) param.getValue()) {
216-
apiUrlBuilder.addParameter(param.getKey() + "[]", single);
217-
}
213+
String joinedValues = StringUtils.join(((Iterable<String>) param.getValue()).iterator(), ",");
214+
apiUrlBuilder.addParameter(param.getKey(), joinedValues);
218215
} else {
219216
apiUrlBuilder.addParameter(param.getKey(), Cloudinary.asString(param.getValue()));
220217
}

0 commit comments

Comments
 (0)