more casting fixes in commands

michalsn · michalsn · commit 4378c4d02076 · 2023-12-19T10:14:33.000+01:00
diff --git a/src/Commands/QueueFlush.php b/src/Commands/QueueFlush.php
@@ -56,6 +56,10 @@ public function run(array $params)
         $hours = $params['hours'] ?? CLI::getOption('hours');
         $queue = $params['queue'] ?? CLI::getOption('queue');
 
+        if ($hours !== null) {
+            $hours = (int) $hours;
+        }
+
         service('queue')->flush($hours, $queue);
 
         if ($hours === null) {
diff --git a/src/Commands/QueueForget.php b/src/Commands/QueueForget.php
@@ -59,7 +59,7 @@ public function run(array $params)
             return EXIT_ERROR;
         }
 
-        if (service('queue')->forget($id)) {
+        if (service('queue')->forget((int) $id)) {
             CLI::write(sprintf('Failed job with ID %s has been removed.', $id), 'green');
         } else {
             CLI::write(sprintf('Could not find the failed job with ID %s', $id), 'red');
diff --git a/src/Commands/QueueRetry.php b/src/Commands/QueueRetry.php
@@ -68,9 +68,7 @@ public function run(array $params)
             return EXIT_ERROR;
         }
 
-        if ($id === 'all') {
-            $id = null;
-        }
+        $id = $id === 'all' ? null : (int) $id;
 
         $queue = $params['queue'] ?? CLI::getOption('queue');
 

Original file line number	Diff line number	Diff line change
`@@ -59,7 +59,7 @@ public function run(array $params)`
`59`	`59`	`return EXIT_ERROR;`
`60`	`60`	`}`
`61`	`61`
`62`		`- if (service('queue')->forget($id)) {`
	`62`	`+ if (service('queue')->forget((int) $id)) {`
`63`	`63`	`CLI::write(sprintf('Failed job with ID %s has been removed.', $id), 'green');`
`64`	`64`	`} else {`
`65`	`65`	`CLI::write(sprintf('Could not find the failed job with ID %s', $id), 'red');`
Original file line number	Diff line number	Diff line change
`@@ -68,9 +68,7 @@ public function run(array $params)`
`68`	`68`	`return EXIT_ERROR;`
`69`	`69`	`}`
`70`	`70`
`71`		`- if ($id === 'all') {`
`72`		`- $id = null;`
`73`		`- }`
	`71`	`+ $id = $id === 'all' ? null : (int) $id;`
`74`	`72`
`75`	`73`	`$queue = $params['queue'] ?? CLI::getOption('queue');`
`76`	`74`