In domain-task, ensure completion callback always fires asynchronously

SteveSandersonMS · SteveSandersonMS · commit b95cd1bc85fb · 2016-03-07T15:27:56.000Z
diff --git a/src/Microsoft.AspNet.SpaServices/npm/domain-task/package.json b/src/Microsoft.AspNet.SpaServices/npm/domain-task/package.json
@@ -1,6 +1,6 @@
 {
   "name": "domain-task",
-  "version": "1.0.0",
+  "version": "1.0.1",
   "description": "Tracks outstanding operations for a logical thread of execution",
   "main": "main.js",
   "scripts": {
diff --git a/src/Microsoft.AspNet.SpaServices/npm/domain-task/src/main.ts b/src/Microsoft.AspNet.SpaServices/npm/domain-task/src/main.ts
@@ -9,14 +9,17 @@ export function addTask(task: PromiseLike<any>) {
             state.numRemainingTasks++;
             task.then(() => {
                 // The application may have other listeners chained to this promise *after*
-                // this listener. Since we don't want the combined task to complete until
-                // all the handlers for child tasks have finished, delay the following by
-                // one tick.
+                // this listener, which may in turn register further tasks. Since we don't 
+                // want the combined task to complete until all the handlers for child tasks
+                // have finished, delay the response to give time for more tasks to be added
+                // synchronously.
                 setTimeout(() => {
                     state.numRemainingTasks--;
                     if (state.numRemainingTasks === 0 && !state.hasIssuedSuccessCallback) {
                         state.hasIssuedSuccessCallback = true;
-                        state.completionCallback(/* error */ null);
+                        setTimeout(() => {
+                            state.completionCallback(/* error */ null);
+                        }, 0);
                     }
                 }, 0);
             }, (error) => {
@@ -42,7 +45,9 @@ export function run<T>(codeToRun: () => T, completionCallback: (error: any) => v
             // If no tasks were registered synchronously, then we're done already
             if (state.numRemainingTasks === 0 && !state.hasIssuedSuccessCallback) {
                 state.hasIssuedSuccessCallback = true;
-                state.completionCallback(/* error */ null);
+                setTimeout(() => {
+                    state.completionCallback(/* error */ null);
+                }, 0);
             }
         } catch(ex) {
             state.completionCallback(ex);

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "domain-task",`
`3`		`- "version": "1.0.0",`
	`3`	`+ "version": "1.0.1",`
`4`	`4`	`"description": "Tracks outstanding operations for a logical thread of execution",`
`5`	`5`	`"main": "main.js",`
`6`	`6`	`"scripts": {`