test: fix env vars in scheduled runs (GoogleCloudPlatform#3459)

kweinmeister · pattishin · web-flow · commit b5798640b774 · 2023-08-16T10:24:16.000-07:00
* test: fix flakybot file upload step

* update env vars

* revert scheduler change

* temp change for testing

* test change to trigger workflow

* revert test changes

* including node 16 update to CI workflow

---------

Co-authored-by: Patti Shin &lt;pattishin@users.noreply.github.com&gt;
diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml
@@ -28,7 +28,7 @@ jobs:
       - uses: actions/checkout@v3.5.3
       - uses: actions/setup-node@v3
         with:
-          node-version: 14
+          node-version: 16
       - run: npm install
       - run: npm run lint
   docs:
diff --git a/.github/workflows/test.yaml b/.github/workflows/test.yaml
@@ -63,18 +63,17 @@ jobs:
     - name: install directory dependencies
       run: npm install
     - run: npm run build --if-present
-    - name: set env vars for scheduled run
+    - name: set testing env vars
+      run: echo "MOCHA_REPORTER_OUTPUT=${{github.run_id}}_sponge_log.xml" >> $GITHUB_ENV
+    - name: set testing env vars for scheduled run
       if: github.event.action == 'schedule'
       run: |
         echo "MOCHA_REPORTER_SUITENAME=${{ inputs.name }}" >> $GITHUB_ENV
-        echo "MOCHA_REPORTER_OUTPUT=${{github.run_id}}_sponge_log.xml" >> $GITHUB_ENV
         echo "MOCHA_REPORTER=xunit" >> $GITHUB_ENV
     - run: npm test
     - name: upload test results for FlakyBot workflow
       if: github.event.action == 'schedule' && always()
       uses: actions/upload-artifact@v3
-      env:
-        MOCHA_REPORTER_OUTPUT: "${{github.run_id}}_sponge_log.xml"
       with:
         name: test-results
         path: ${{ inputs.path }}/${{ env.MOCHA_REPORTER_OUTPUT }}
