chore: remove unused dependencies (GoogleCloudPlatform#3168)

kweinmeister · web-flow · commit 85bf18f27c88 · 2023-04-25T08:04:33.000-05:00
* ci: regenerate workflows with updated template

* address test failures

* updates

* updates

* more workflows

* increase security center test output buffer

* security center test issue

* add missing workflows

* update workflows

* update test timeout

* additional changes for timeout

* add aiplatform fix

* add aiplatform skip

* remove skip on deny test

* skip iam test

* chore: remove unused dependencies

* remove additional dep

* reverting run jobs due to unrelated build failure

* revert idp-sql

* remove unnecessary files

* fix owlbot error

* revert owlbot changes

* final owlbot change
diff --git a/appengine/building-an-app/build/package.json b/appengine/building-an-app/build/package.json
@@ -23,7 +23,6 @@
   },
   "devDependencies": {
     "mocha": "^10.0.0",
-    "supertest": "^6.0.0",
-    "proxyquire": "^2.1.3"
+    "supertest": "^6.0.0"
   }
 }
diff --git a/appengine/typescript/package.json b/appengine/typescript/package.json
@@ -22,6 +22,7 @@
     "gcp-build": "tsc -p ."
   },
   "dependencies": {
+    "@typescript-eslint/parser": "^5.59.0",
     "express": "^4.16.3"
   },
   "devDependencies": {
diff --git a/asset/snippets/package.json b/asset/snippets/package.json
@@ -19,8 +19,7 @@
     "@google-cloud/bigquery": "^6.0.0",
     "@google-cloud/compute": "^3.0.0",
     "@google-cloud/resource-manager": "^4.1.1",
-    "@google-cloud/storage": "^6.0.0",
-    "yargs": "^17.0.0"
+    "@google-cloud/storage": "^6.0.0"
   },
   "devDependencies": {
     "chai": "^4.2.0",
diff --git a/automl/package.json b/automl/package.json
@@ -17,9 +17,7 @@
   ],
   "dependencies": {
     "@google-cloud/automl": "^3.1.2",
-    "csv": "^6.0.0",
-    "mathjs": "^11.0.0",
-    "yargs": "^17.0.0"
+    "mathjs": "^11.0.0"
   },
   "devDependencies": {
     "@google-cloud/storage": "^6.0.0",
diff --git a/batch/package.json b/batch/package.json
@@ -18,7 +18,6 @@
   },
   "devDependencies": {
     "c8": "^7.1.0",
-    "chai": "^4.2.0",
     "mocha": "^10.0.0",
     "nanoid": "^3.3.0",
     "@google-cloud/storage": "^6.7.0",
diff --git a/cloud-language/package.json b/cloud-language/package.json
@@ -15,13 +15,11 @@
     "test": "mocha --timeout 60000"
   },
   "dependencies": {
-    "mathjs": "^11.0.0",
     "@google-cloud/language": "^5.1.0",
     "@google-cloud/storage": "^6.0.0",
     "yargs": "^17.0.0"
   },
   "devDependencies": {
-    "@google-cloud/automl": "^3.0.0",
     "chai": "^4.2.0",
     "mocha": "^10.0.0",
     "uuid": "^9.0.0"
diff --git a/cloud-sql/mysql/mysql/package.json b/cloud-sql/mysql/mysql/package.json
@@ -27,8 +27,6 @@
   },
   "devDependencies": {
     "mocha": "^10.0.0",
-    "proxyquire": "^2.1.0",
-    "supertest": "^6.0.0",
-    "sinon": "^15.0.0"
+    "supertest": "^6.0.0"
   }
 }
diff --git a/cloud-sql/postgres/knex/package.json b/cloud-sql/postgres/knex/package.json
@@ -24,8 +24,7 @@
     "knex": "^2.0.0",
     "pg": "^8.0.0",
     "pug": "^3.0.0",
-    "winston": "^3.1.0",
-    "yargs": "^17.0.0"
+    "winston": "^3.1.0"
   },
   "devDependencies": {
     "mocha": "^10.0.0",
diff --git a/container/snippets/package.json b/container/snippets/package.json
@@ -18,7 +18,6 @@
   },
   "devDependencies": {
     "chai": "^4.2.0",
-    "mocha": "^10.0.0",
-    "uuid": "^9.0.0"
+    "mocha": "^10.0.0"
   }
 }
diff --git a/dlp/package.json b/dlp/package.json
@@ -17,8 +17,7 @@
   "dependencies": {
     "@google-cloud/dlp": "^4.3.0",
     "@google-cloud/pubsub": "^3.0.0",
-    "mime": "^3.0.0",
-    "yargs": "^17.0.0"
+    "mime": "^3.0.0"
   },
   "devDependencies": {
     "chai": "^4.2.0",
diff --git a/endpoints/getting-started-grpc/package.json b/endpoints/getting-started-grpc/package.json
@@ -17,9 +17,7 @@
     "test": "mocha --exit system-test/*.test.js --timeout=60000"
   },
   "dependencies": {
-    "google-auth-library": "^8.0.0",
     "grpc": "^1.18.0",
-    "jsonwebtoken": "^9.0.0",
     "yargs": "^17.0.0"
   },
   "devDependencies": {
diff --git a/eventarc/pubsub/package.json b/eventarc/pubsub/package.json
@@ -27,8 +27,6 @@
   "devDependencies": {
     "got": "^11.5.0",
     "mocha": "^10.0.0",
-    "sinon": "^15.0.0",
-    "supertest": "^6.0.0",
-    "uuid": "^9.0.0"
+    "supertest": "^6.0.0"
   }
 }
diff --git a/functions/helloworld/helloGCS/package.json b/functions/helloworld/helloGCS/package.json
@@ -18,8 +18,7 @@
     "test": "npm -- run unit-test"
   },
   "dependencies": {
-    "@google-cloud/functions-framework": "^3.1.0",
-    "escape-html": "^1.0.3"
+    "@google-cloud/functions-framework": "^3.1.0"
   },
   "devDependencies": {
     "@google-cloud/storage": "^6.0.0",
@@ -28,7 +27,6 @@
     "moment": "^2.24.0",
     "promise-retry": "^2.0.0",
     "sinon": "^15.0.0",
-    "supertest": "^6.0.0",
     "uuid": "^9.0.0",
     "wait-port": "^1.0.4"
   }
diff --git a/functions/helloworld/helloPubSub/package.json b/functions/helloworld/helloPubSub/package.json
@@ -24,9 +24,9 @@
     "@google-cloud/pubsub": "^3.0.0",
     "gaxios": "^5.0.0",
     "mocha": "^10.0.0",
+    "moment": "^2.29.4",
     "promise-retry": "^2.0.0",
     "sinon": "^15.0.0",
-    "supertest": "^6.0.0",
     "uuid": "^9.0.0",
     "wait-port": "^1.0.4"
   }
diff --git a/functions/helloworld/helloworldGet/package.json b/functions/helloworld/helloworldGet/package.json
@@ -20,8 +20,6 @@
   "devDependencies": {
     "gaxios": "^5.0.1",
     "mocha": "^10.0.0",
-    "promise-retry": "^2.0.0",
-    "supertest": "^6.0.0",
     "wait-port": "^1.0.4"
   }
 }
diff --git a/functions/helloworld/helloworldHttp/package.json b/functions/helloworld/helloworldHttp/package.json
@@ -24,11 +24,8 @@
   "devDependencies": {
     "gaxios": "^5.0.0",
     "mocha": "^10.0.0",
-    "moment": "^2.24.0",
-    "promise-retry": "^2.0.0",
     "sinon": "^15.0.0",
     "supertest": "^6.0.0",
-    "uuid": "^9.0.0",
     "wait-port": "^1.0.4"
   }
 }
diff --git a/functions/log/helloWorld/package.json b/functions/log/helloWorld/package.json
@@ -16,7 +16,6 @@
   },
   "devDependencies": {
     "mocha": "^10.0.0",
-    "proxyquire": "^2.1.0",
     "sinon": "^15.0.0"
   },
   "dependencies": {
diff --git a/functions/v2/cloudEventLogging/package.json b/functions/v2/cloudEventLogging/package.json
@@ -16,7 +16,6 @@
     "@google-cloud/logging": "^10.0.0"
   },
   "devDependencies": {
-    "assert": "^2.0.0",
     "cloudevents": "^6.0.1",
     "mocha": "^10.0.0",
     "sinon": "^15.0.0"
diff --git a/functions/v2/firebase/firestore/helloFirestore/package.json b/functions/v2/firebase/firestore/helloFirestore/package.json
@@ -16,7 +16,6 @@
   },
   "devDependencies": {
     "mocha": "^10.0.0",
-    "proxyquire": "^2.1.0",
     "sinon": "^15.0.0"
   },
   "dependencies": {
diff --git a/functions/v2/firebase/firestore/makeUpperCase/package.json b/functions/v2/firebase/firestore/makeUpperCase/package.json
@@ -16,7 +16,6 @@
   },
   "devDependencies": {
     "mocha": "^10.0.0",
-    "proxyquire": "^2.1.0",
     "sinon": "^15.0.0",
     "rewire": "^6.0.0"
   },
diff --git a/functions/v2/helloAuditLog/package.json b/functions/v2/helloAuditLog/package.json
@@ -19,10 +19,7 @@
   },
   "devDependencies": {
     "mocha": "^10.0.0",
-    "p-retry": "^5.0.0",
     "sinon": "^15.0.0",
-    "supertest": "^6.0.0",
-    "uuid": "^9.0.0",
     "supertest": "^6.0.0"
   }
 }
diff --git a/functions/v2/helloGCS/package.json b/functions/v2/helloGCS/package.json
@@ -19,7 +19,6 @@
   },
   "devDependencies": {
     "mocha": "^10.0.0",
-    "p-retry": "^5.0.0",
     "sinon": "^15.0.0",
     "supertest": "^6.0.0"
   }
diff --git a/functions/v2/httpLogging/package.json b/functions/v2/httpLogging/package.json
@@ -17,8 +17,6 @@
     "@google-cloud/logging": "^10.0.0"
   },
   "devDependencies": {
-    "assert": "^2.0.0",
-    "child_process": "^1.0.2",
     "mocha": "^10.0.0",
     "sinon": "^15.0.0"
   }
diff --git a/healthcare/datasets/package.json b/healthcare/datasets/package.json
@@ -13,7 +13,6 @@
   },
   "devDependencies": {
     "mocha": "^10.0.0",
-    "mocha-test": "^2.0.4",
     "uuid": "^9.0.0"
   },
   "dependencies": {
diff --git a/owlbot.py b/owlbot.py
@@ -49,11 +49,11 @@ def walk_through_owlbot_dirs(dir: Path, search_for_changed_files: bool) -> list[
                 ["git", "fetch", "origin", "main:main", "--deepen=200"], check=False
             )
             output.check_returncode()
-        except subprocess.CalledProcessError as e:
-            if e.returncode == 128:
+        except subprocess.CalledProcessError as error:
+            if error.returncode == 128:
                 logger.info(f"Error: ${e.output}; skipping fetching main")
             else:
-                raise e
+                raise error
     for path_object in dir.glob("**/package.json"):
         object_dir = str(Path(path_object).parents[0])
         if (
diff --git a/package.json b/package.json
@@ -17,24 +17,18 @@
     "test": "echo 'Please run tests in each sample directory.' && exit 1",
     "generate-ci": "node .github/workflows/generate.js"
   },
-  "devDependencies": {
-    "@typescript-eslint/eslint-plugin": "^5.52.0",
-    "@typescript-eslint/parser": "^5.52.0",
-    "gts": "^3.1.0",
-    "nunjucks": "^3.2.3",
-    "typescript": "^5.0.0"
+  "devDependencies": {    
+    "@typescript-eslint/eslint-plugin": "^5.59.0",
+    "@typescript-eslint/parser": "^5.59.0",
+    "eslint-plugin-node": "^11.1.0",
+    "eslint-plugin-prettier": "^4.2.1",
+    "eslint-config-prettier": "^8.8.0",
+    "gts": "^3.1.1",
+    "nunjucks": "^3.2.4",
+    "prettier": "^2.8.7",
+    "typescript": "^5.0.4"
   },
   "dependencies": {
-    "@google-cloud/asset": "^4.5.0",
-    "@google-cloud/bigquery": "^6.0.3",
-    "@google-cloud/compute": "^3.6.0",
-    "@google-cloud/resource-manager": "^4.1.1",
-    "@google-cloud/storage": "^6.7.0",
-    "chai": "^4.3.7",
-    "commander": "^10.0.0",
-    "express": "^4.18.2",
-    "mocha": "^10.1.0",
-    "prettier": "^2.8.4",
-    "uuid": "^9.0.0"
+    "commander": "^10.0.1"
   }
 }
diff --git a/scheduler/package.json b/scheduler/package.json
@@ -17,17 +17,13 @@
     "test": "mocha --loader=ts-node/esm --extension ts --timeout 10000 --exit"
   },
   "dependencies": {
-    "@google-cloud/scheduler": "^3.2.1",
-    "body-parser": "^1.20.1",
-    "express": "^4.18.2"
+    "@google-cloud/scheduler": "^3.2.1"
   },
   "devDependencies": {
     "@types/chai": "^4.3.4",
-    "@types/express": "^4.17.17",
     "@types/mocha": "^10.0.1",
     "@types/node": "^18.13.0",
     "chai": "^4.3.7",
-    "eslint": "^8.34.0",
     "gts": "^3.1.1",
     "mocha": "^10.2.0",
     "ts-node": "^10.9.1",
diff --git a/speech/package.json b/speech/package.json
@@ -15,17 +15,12 @@
     "test": "c8 mocha system-test --timeout 600000"
   },
   "dependencies": {
-    "@google-cloud/resource-manager": "^4.1.1",
     "@google-cloud/speech": "^5.1.0",
     "@google-cloud/storage": "^6.0.0",
     "chalk": "^5.0.0",
     "fs.promises": "^0.1.2",
-    "google-proto-files": "^3.0.0",
     "node-record-lpcm16": "^1.0.1",
-    "proto3-json-serializer": "^1.0.0",
-    "protobufjs": "^7.0.0",
     "sinon": "^15.0.0",
-    "sox": "^0.1.0",
     "yargs": "^17.0.0"
   },
   "devDependencies": {

Original file line number	Diff line number	Diff line change
`@@ -23,7 +23,6 @@`
`23`	`23`	`},`
`24`	`24`	`"devDependencies": {`
`25`	`25`	`"mocha": "^10.0.0",`
`26`		`- "supertest": "^6.0.0",`
`27`		`- "proxyquire": "^2.1.3"`
	`26`	`+ "supertest": "^6.0.0"`
`28`	`27`	`}`
`29`	`28`	`}`
Original file line number	Diff line number	Diff line change
`@@ -27,8 +27,6 @@`
`27`	`27`	`},`
`28`	`28`	`"devDependencies": {`
`29`	`29`	`"mocha": "^10.0.0",`
`30`		`- "proxyquire": "^2.1.0",`
`31`		`- "supertest": "^6.0.0",`
`32`		`- "sinon": "^15.0.0"`
	`30`	`+ "supertest": "^6.0.0"`
`33`	`31`	`}`
`34`	`32`	`}`
Original file line number	Diff line number	Diff line change
`@@ -18,7 +18,6 @@`
`18`	`18`	`},`
`19`	`19`	`"devDependencies": {`
`20`	`20`	`"chai": "^4.2.0",`
`21`		`- "mocha": "^10.0.0",`
`22`		`- "uuid": "^9.0.0"`
	`21`	`+ "mocha": "^10.0.0"`
`23`	`22`	`}`
`24`	`23`	`}`