From 881e24995b573dfd697b42628e47df5d822e5799 Mon Sep 17 00:00:00 2001 From: nicholas-codecov Date: Thu, 13 Jul 2023 12:12:29 -0400 Subject: [PATCH] remove section on assigning reviewers. should only be requesting when needed --- CONTRIBUTING.md | 4 ---- 1 file changed, 4 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index dcda51e..c32de21 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -287,10 +287,6 @@ Please be pragmatic, and consider the cost of each incremental request for chang - You’ll often catch code mistakes you didn’t see when writing it. - This is also a good time to leave comments and refresh your memory in order to write a more helpful description. -### Assign no more than 1-3 reviewers -- It’s tempting to want to involve as many people as possible, but it can often be distracting, and create a situation where nobody’s clear on who should actually perform the review. -- If your work spans multiple teams (and thus, many reviewers), consider breaking up your PR into multiple compatible patches (e.g. a back-end change and a front-end change). - ### Avoid rebasing unnecessarily - After a rebase, previous review comments will be orphaned from their now non-existent parent commits, making review more difficult