test: add missing calls to napi_async_destroy

addaleax · addaleax · commit ff38ec0471f0 · 2020-04-30T04:52:04.000+02:00
PR-URL: nodejs#33114 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
diff --git a/test/node-api/test_callback_scope/binding.cc b/test/node-api/test_callback_scope/binding.cc
@@ -47,6 +47,7 @@ napi_value RunInCallbackScope(napi_env env, napi_callback_info info) {
   }
 
   NAPI_CALL(env, napi_close_callback_scope(env, scope));
+  NAPI_CALL(env, napi_async_destroy(env, context));
 
   return result;
 }
@@ -85,6 +86,7 @@ static void Callback(uv_work_t* req, int ignored) {
   NAPI_CALL_RETURN_VOID(env, napi_close_callback_scope(env, scope));
 
   NAPI_CALL_RETURN_VOID(env, napi_close_handle_scope(env, handle_scope));
+  NAPI_CALL_RETURN_VOID(env, napi_async_destroy(env, context));
   delete req;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -47,6 +47,7 @@ napi_value RunInCallbackScope(napi_env env, napi_callback_info info) {`
`47`	`47`	`}`
`48`	`48`
`49`	`49`	`NAPI_CALL(env, napi_close_callback_scope(env, scope));`
	`50`	`+ NAPI_CALL(env, napi_async_destroy(env, context));`
`50`	`51`
`51`	`52`	`return result;`
`52`	`53`	`}`
`@@ -85,6 +86,7 @@ static void Callback(uv_work_t* req, int ignored) {`
`85`	`86`	`NAPI_CALL_RETURN_VOID(env, napi_close_callback_scope(env, scope));`
`86`	`87`
`87`	`88`	`NAPI_CALL_RETURN_VOID(env, napi_close_handle_scope(env, handle_scope));`
	`89`	`+ NAPI_CALL_RETURN_VOID(env, napi_async_destroy(env, context));`
`88`	`90`	`delete req;`
`89`	`91`	`}`
`90`	`92`