CLOUDSTACK-4281 : Usage - exception was hiding the db error. Make the usage job fail incase of any DB insert exceptions

Kishan Kavala · Kishan Kavala · commit b4464d88d34f · 2013-08-13T17:30:46.000+05:30
diff --git a/usage/src/com/cloud/usage/parser/NetworkUsageParser.java b/usage/src/com/cloud/usage/parser/NetworkUsageParser.java
@@ -129,11 +129,8 @@ public static boolean parse(AccountVO account, Date startDate, Date endDate) {
                 }
             }
         }
-        try {
-            m_usageDao.saveUsageRecords(usageRecords);
-        } catch (Exception ex) {
-            s_logger.error("Exception in usage manager", ex);
-        }
+
+        m_usageDao.saveUsageRecords(usageRecords);
 
         return true;
     }
diff --git a/usage/src/com/cloud/usage/parser/VmDiskUsageParser.java b/usage/src/com/cloud/usage/parser/VmDiskUsageParser.java
@@ -157,11 +157,7 @@ public static boolean parse(AccountVO account, Date startDate, Date endDate) {
             }
         }
 
-        try {
-            m_usageDao.saveUsageRecords(usageRecords);
-        } catch (Exception ex) {
-            s_logger.error("Exception in usage manager", ex);
-        }
+        m_usageDao.saveUsageRecords(usageRecords);
 
         return true;
     }

Original file line number	Diff line number	Diff line change
`@@ -129,11 +129,8 @@ public static boolean parse(AccountVO account, Date startDate, Date endDate) {`
`129`	`129`	`}`
`130`	`130`	`}`
`131`	`131`	`}`
`132`		`- try {`
`133`		`- m_usageDao.saveUsageRecords(usageRecords);`
`134`		`- } catch (Exception ex) {`
`135`		`- s_logger.error("Exception in usage manager", ex);`
`136`		`- }`
	`132`	`+`
	`133`	`+ m_usageDao.saveUsageRecords(usageRecords);`
`137`	`134`
`138`	`135`	`return true;`
`139`	`136`	`}`
Original file line number	Diff line number	Diff line change
`@@ -157,11 +157,7 @@ public static boolean parse(AccountVO account, Date startDate, Date endDate) {`
`157`	`157`	`}`
`158`	`158`	`}`
`159`	`159`
`160`		`- try {`
`161`		`- m_usageDao.saveUsageRecords(usageRecords);`
`162`		`- } catch (Exception ex) {`
`163`		`- s_logger.error("Exception in usage manager", ex);`
`164`		`- }`
	`160`	`+ m_usageDao.saveUsageRecords(usageRecords);`
`165`	`161`
`166`	`162`	`return true;`
`167`	`163`	`}`