CID-1116300 Prevent potential NPE

spark404 · spark404 · commit 90df7cf88144 · 2014-09-19T11:55:17.000+02:00
diff --git a/core/src/com/cloud/resource/ServerResourceBase.java b/core/src/com/cloud/resource/ServerResourceBase.java
@@ -122,6 +122,10 @@ public boolean configure(final String name, Map<String, Object> params) throws C
             }
         }
         String infos[] = NetUtils.getNetworkParams(_privateNic);
+        if (infos == null) {
+            s_logger.warn("Incorrect details for private Nic during initialization of ServerResourceBase");
+            return false;
+        }
         params.put("host.ip", infos[0]);
         params.put("host.mac.address", infos[1]);
 

Original file line number	Diff line number	Diff line change
`@@ -122,6 +122,10 @@ public boolean configure(final String name, Map<String, Object> params) throws C`
`122`	`122`	`}`
`123`	`123`	`}`
`124`	`124`	`String infos[] = NetUtils.getNetworkParams(_privateNic);`
	`125`	`+ if (infos == null) {`
	`126`	`+ s_logger.warn("Incorrect details for private Nic during initialization of ServerResourceBase");`
	`127`	`+ return false;`
	`128`	`+ }`
`125`	`129`	`params.put("host.ip", infos[0]);`
`126`	`130`	`params.put("host.mac.address", infos[1]);`
`127`	`131`