Made a bit more sense of exceptions with inheritance

doihaveto · doihaveto · commit 731efc9f44d1 · 2016-02-22T14:44:36.000+02:00
diff --git a/ebaysdk/exception.py b/ebaysdk/exception.py
@@ -6,46 +6,26 @@
 Licensed under CDDL 1.0
 '''
 
-class ConnectionError(Exception):
-    def __init__(self, msg, response):
-        super(ConnectionError, self).__init__(u'%s' % msg)
+class EbaySDKError(StandardError):
+    def __init__(self, msg, response=None):
+        super(EbaySDKError, self).__init__(u'%s' % msg)
         self.message = u'%s' % msg
         self.response = response
 
     def __str__(self):
         return repr(self.message)
 
-class ConnectionConfigError(Exception):
-    def __init__(self, msg):
-        super(ConnectionConfigError, self).__init__(u'%s' % msg)
-        self.message = u'%s' % msg
-
-    def __str__(self):
-        return repr(self.message)
-
-class ConnectionResponseError(Exception):
-    def __init__(self, msg, response):
-        super(ConnectionResponseError, self).__init__(u'%s' % msg)
-        self.message = u'%s' % msg
-        self.response = response
-
-    def __str__(self):
-        return repr(self.message)
+class ConnectionError(EbaySDKError):
+    pass
 
-class RequestPaginationError(Exception):
-    def __init__(self, msg, response):
-        super(RequestPaginationError, self).__init__(u'%s' % msg)
-        self.message = u'%s' % msg
-        self.response = response
+class ConnectionConfigError(EbaySDKError):
+    pass
 
-    def __str__(self):
-        return repr(self.message)
+class ConnectionResponseError(EbaySDKError):
+    pass
 
-class PaginationLimit(Exception):
-    def __init__(self, msg, response):
-        super(PaginationLimit, self).__init__(u'%s' % msg)
-        self.message = u'%s' % msg
-        self.response = response
+class RequestPaginationError(EbaySDKError):
+    pass
 
-    def __str__(self):
-        return repr(self.message)
+class PaginationLimit(EbaySDKError):
+    pass
