refactor(platform-browser): reduce runtime code size of shared style host (angular#57834)

clydin · pkozlowski-opensource · commit 7b2fda16b1bc · 2024-09-23T14:22:58.000+02:00
The `SharedStylesHost` class has been refactored to both reduce the runtime code size and also modernize some of the code structures. The class is also adjusted to better support reuse via subclassing or other reuses in the future. Additional comments have been added to improve readability as well. The code reduction in a prerelease newly generated Angular CLI application for production is ~410 bytes. Before: ``` Initial chunk files | Names | Raw size | Estimated transfer size main-GOQKBZBZ.js | main | 208.67 kB | 56.41 kB polyfills-FFHMD2TL.js | polyfills | 34.52 kB | 11.28 kB styles-5INURTSO.css | styles | 0 bytes | 0 bytes | Initial total | 243.19 kB | 67.69 kB ``` After: ``` Initial chunk files | Names | Raw size | Estimated transfer size main-CRTDDKPH.js | main | 208.26 kB | 56.32 kB polyfills-FFHMD2TL.js | polyfills | 34.52 kB | 11.28 kB styles-5INURTSO.css | styles | 0 bytes | 0 bytes | Initial total | 242.78 kB | 67.61 kB ``` PR Close angular#57834
diff --git a/packages/core/test/bundling/animations-standalone/bundle.golden_symbols.json b/packages/core/test/bundling/animations-standalone/bundle.golden_symbols.json
@@ -1355,6 +1355,9 @@
   {
     "name": "remove"
   },
+  {
+    "name": "removeAll"
+  },
   {
     "name": "removeClass"
   },
diff --git a/packages/core/test/bundling/animations/bundle.golden_symbols.json b/packages/core/test/bundling/animations/bundle.golden_symbols.json
@@ -1430,6 +1430,9 @@
   {
     "name": "remove"
   },
+  {
+    "name": "removeAll"
+  },
   {
     "name": "removeClass"
   },
diff --git a/packages/core/test/bundling/cyclic_import/bundle.golden_symbols.json b/packages/core/test/bundling/cyclic_import/bundle.golden_symbols.json
@@ -1157,6 +1157,9 @@
   {
     "name": "remove"
   },
+  {
+    "name": "removeAll"
+  },
   {
     "name": "removeFromArray"
   },
diff --git a/packages/core/test/bundling/defer/bundle.golden_symbols.json b/packages/core/test/bundling/defer/bundle.golden_symbols.json
@@ -2405,6 +2405,9 @@
   {
     "name": "remove"
   },
+  {
+    "name": "removeAll"
+  },
   {
     "name": "removeFromArray"
   },
diff --git a/packages/core/test/bundling/forms_reactive/bundle.golden_symbols.json b/packages/core/test/bundling/forms_reactive/bundle.golden_symbols.json
@@ -1724,6 +1724,9 @@
   {
     "name": "remove"
   },
+  {
+    "name": "removeAll"
+  },
   {
     "name": "removeFromArray"
   },
diff --git a/packages/core/test/bundling/forms_template_driven/bundle.golden_symbols.json b/packages/core/test/bundling/forms_template_driven/bundle.golden_symbols.json
@@ -1691,6 +1691,9 @@
   {
     "name": "remove"
   },
+  {
+    "name": "removeAll"
+  },
   {
     "name": "removeFromArray"
   },
diff --git a/packages/core/test/bundling/hydration/bundle.golden_symbols.json b/packages/core/test/bundling/hydration/bundle.golden_symbols.json
@@ -1268,6 +1268,9 @@
   {
     "name": "remove"
   },
+  {
+    "name": "removeAll"
+  },
   {
     "name": "removeDehydratedView"
   },
diff --git a/packages/core/test/bundling/router/bundle.golden_symbols.json b/packages/core/test/bundling/router/bundle.golden_symbols.json
@@ -1964,6 +1964,9 @@
   {
     "name": "remove"
   },
+  {
+    "name": "removeAll"
+  },
   {
     "name": "removeFromArray"
   },
diff --git a/packages/core/test/bundling/standalone_bootstrap/bundle.golden_symbols.json b/packages/core/test/bundling/standalone_bootstrap/bundle.golden_symbols.json
@@ -1019,6 +1019,9 @@
   {
     "name": "remove"
   },
+  {
+    "name": "removeAll"
+  },
   {
     "name": "removeFromArray"
   },
diff --git a/packages/core/test/bundling/todo/bundle.golden_symbols.json b/packages/core/test/bundling/todo/bundle.golden_symbols.json
@@ -1373,6 +1373,9 @@
   {
     "name": "remove"
   },
+  {
+    "name": "removeAll"
+  },
   {
     "name": "removeFromArray"
   },
diff --git a/packages/platform-browser/src/dom/shared_styles_host.ts b/packages/platform-browser/src/dom/shared_styles_host.ts

Original file line number	Diff line number	Diff line change
`@@ -1355,6 +1355,9 @@`
`1355`	`1355`	`{`
`1356`	`1356`	`"name": "remove"`
`1357`	`1357`	`},`
	`1358`	`+ {`
	`1359`	`+ "name": "removeAll"`
	`1360`	`+ },`
`1358`	`1361`	`{`
`1359`	`1362`	`"name": "removeClass"`
`1360`	`1363`	`},`
Original file line number	Diff line number	Diff line change
`@@ -1430,6 +1430,9 @@`
`1430`	`1430`	`{`
`1431`	`1431`	`"name": "remove"`
`1432`	`1432`	`},`
	`1433`	`+ {`
	`1434`	`+ "name": "removeAll"`
	`1435`	`+ },`
`1433`	`1436`	`{`
`1434`	`1437`	`"name": "removeClass"`
`1435`	`1438`	`},`
Original file line number	Diff line number	Diff line change
`@@ -1157,6 +1157,9 @@`
`1157`	`1157`	`{`
`1158`	`1158`	`"name": "remove"`
`1159`	`1159`	`},`
	`1160`	`+ {`
	`1161`	`+ "name": "removeAll"`
	`1162`	`+ },`
`1160`	`1163`	`{`
`1161`	`1164`	`"name": "removeFromArray"`
`1162`	`1165`	`},`
Original file line number	Diff line number	Diff line change
`@@ -2405,6 +2405,9 @@`
`2405`	`2405`	`{`
`2406`	`2406`	`"name": "remove"`
`2407`	`2407`	`},`
	`2408`	`+ {`
	`2409`	`+ "name": "removeAll"`
	`2410`	`+ },`
`2408`	`2411`	`{`
`2409`	`2412`	`"name": "removeFromArray"`
`2410`	`2413`	`},`
Original file line number	Diff line number	Diff line change
`@@ -1724,6 +1724,9 @@`
`1724`	`1724`	`{`
`1725`	`1725`	`"name": "remove"`
`1726`	`1726`	`},`
	`1727`	`+ {`
	`1728`	`+ "name": "removeAll"`
	`1729`	`+ },`
`1727`	`1730`	`{`
`1728`	`1731`	`"name": "removeFromArray"`
`1729`	`1732`	`},`
Original file line number	Diff line number	Diff line change
`@@ -1691,6 +1691,9 @@`
`1691`	`1691`	`{`
`1692`	`1692`	`"name": "remove"`
`1693`	`1693`	`},`
	`1694`	`+ {`
	`1695`	`+ "name": "removeAll"`
	`1696`	`+ },`
`1694`	`1697`	`{`
`1695`	`1698`	`"name": "removeFromArray"`
`1696`	`1699`	`},`
Original file line number	Diff line number	Diff line change
`@@ -1268,6 +1268,9 @@`
`1268`	`1268`	`{`
`1269`	`1269`	`"name": "remove"`
`1270`	`1270`	`},`
	`1271`	`+ {`
	`1272`	`+ "name": "removeAll"`
	`1273`	`+ },`
`1271`	`1274`	`{`
`1272`	`1275`	`"name": "removeDehydratedView"`
`1273`	`1276`	`},`
Original file line number	Diff line number	Diff line change
`@@ -1964,6 +1964,9 @@`
`1964`	`1964`	`{`
`1965`	`1965`	`"name": "remove"`
`1966`	`1966`	`},`
	`1967`	`+ {`
	`1968`	`+ "name": "removeAll"`
	`1969`	`+ },`
`1967`	`1970`	`{`
`1968`	`1971`	`"name": "removeFromArray"`
`1969`	`1972`	`},`
Original file line number	Diff line number	Diff line change
`@@ -1019,6 +1019,9 @@`
`1019`	`1019`	`{`
`1020`	`1020`	`"name": "remove"`
`1021`	`1021`	`},`
	`1022`	`+ {`
	`1023`	`+ "name": "removeAll"`
	`1024`	`+ },`
`1022`	`1025`	`{`
`1023`	`1026`	`"name": "removeFromArray"`
`1024`	`1027`	`},`
Original file line number	Diff line number	Diff line change
`@@ -1373,6 +1373,9 @@`
`1373`	`1373`	`{`
`1374`	`1374`	`"name": "remove"`
`1375`	`1375`	`},`
	`1376`	`+ {`
	`1377`	`+ "name": "removeAll"`
	`1378`	`+ },`
`1376`	`1379`	`{`
`1377`	`1380`	`"name": "removeFromArray"`
`1378`	`1381`	`},`