ci: update default circle ci image to cimg/node:14.17.6 (angular#43810)

alan-agius4 · atscott · commit 64111282844f · 2021-10-12T17:43:15.000Z
With this change we update Node.js version to 14.17 which is needed because of Eslint 8. Also, we replace the legacy images `circleci/node` with the new images `cimg/node`. See: https://circleci.com/developer/images/image/cimg/node PR Close angular#43810
diff --git a/.circleci/config.yml b/.circleci/config.yml
@@ -24,15 +24,15 @@ version: 2.1
 # **NOTE 2 **: If you change the cache key prefix, also sync the cache_key_fallback to match.
 # **NOTE 3 **: Keep the static part of the cache key as prefix to enable correct fallbacks.
 # See https://circleci.com/docs/2.0/caching/#restoring-cache for how prefixes work in CircleCI.
-var_3: &cache_key v5-angular-node-14-{{ checksum "month.txt" }}-{{ checksum ".bazelversion" }}-{{ checksum "yarn.lock" }}-{{ checksum "WORKSPACE" }}-{{ checksum "aio/yarn.lock" }}
+var_3: &cache_key v6-angular-node-14-{{ checksum "month.txt" }}-{{ checksum ".bazelversion" }}-{{ checksum "yarn.lock" }}-{{ checksum "WORKSPACE" }}-{{ checksum "aio/yarn.lock" }}
 # We invalidate the cache if the Bazel version changes because otherwise the `bazelisk` cache
 # folder will contain all previously used versions and ultimately cause the cache restoring to
 # be slower due to its growing size.
-var_4: &cache_key_fallback v5-angular-node-14-{{ checksum "month.txt" }}-{{ checksum ".bazelversion" }}
+var_4: &cache_key_fallback v6-angular-node-14-{{ checksum "month.txt" }}-{{ checksum ".bazelversion" }}
 
 # Windows needs its own cache key because binaries in node_modules are different.
-var_3_win: &cache_key_win v5-angular-win-node-14-{{ checksum "month.txt" }}-{{ checksum ".bazelversion" }}-{{ checksum "yarn.lock" }}-{{ checksum "WORKSPACE" }}-{{ checksum "aio/yarn.lock" }}
-var_4_win: &cache_key_win_fallback v5-angular-win-node-14-{{ checksum "month.txt" }}-{{ checksum ".bazelversion" }}
+var_3_win: &cache_key_win v6-angular-win-node-14-{{ checksum "month.txt" }}-{{ checksum ".bazelversion" }}-{{ checksum "yarn.lock" }}-{{ checksum "WORKSPACE" }}-{{ checksum "aio/yarn.lock" }}
+var_4_win: &cache_key_win_fallback v6-angular-win-node-14-{{ checksum "month.txt" }}-{{ checksum ".bazelversion" }}
 
 # Cache key for the `components-repo-unit-tests` job. **Note** when updating the SHA in the
 # cache keys also update the SHA for the "COMPONENTS_REPO_COMMIT" environment variable.
@@ -86,7 +86,7 @@ executors:
         type: string
         default: medium
     docker:
-      - image: circleci/node:14.16.1@sha256:951e12268fe692615bfd155c327bd910e10c99db98404badd03879f984c32b31
+      - image: cimg/node:14.17.6@sha256:589b5e494173bfb48923fa8d29b010b4d17079ac98d08de95dd4a78e57f5aa0b
     resource_class: << parameters.resource_class >>
     working_directory: ~/ng
 
@@ -131,7 +131,7 @@ commands:
             # and network security service libraries (libnss3) & X11 Screen Saver extension library (libssx1)
             # which are dependencies of chrome & needed for karma & protractor headless chrome tests.
             # This is a very small install which takes around 7s in comparing to using the full
-            # circleci/node:x.x.x-browsers image.
+            # cimg/node:x.x.x-browsers image.
             sudo apt-get -y install libgtk-3-0 libasound2 libnss3 libxss1
 
   # Install java runtime which is required by some integration tests such as
diff --git a/.circleci/windows-env.ps1 b/.circleci/windows-env.ps1
@@ -41,8 +41,8 @@ copy .circleci\bazel.windows.rc ${Env:USERPROFILE}\.bazelrc
 ####################################################################################################
 # Install specific version of node.
 ####################################################################################################
-nvm install 14.16.1
-nvm use 14.16.1
+nvm install 14.17.6
+nvm use 14.17.6
 
 # These Bazel prereqs aren't needed because the CircleCI image already includes them.
 # choco install yarn --version 1.16.0 --no-progress
diff --git a/.devcontainer/recommended-Dockerfile b/.devcontainer/recommended-Dockerfile
@@ -1,7 +1,7 @@
 # Image metadata and config.
 # Ideally, the Node.js version should match what we use on CI.
 # See `executors > default-executor` in `.circleci/config.yml`.
-FROM circleci/node:14-browsers
+FROM cimg/node:14-browsers
 
 
 LABEL name="Angular dev environment" \
diff --git a/.nvmrc b/.nvmrc
@@ -1 +1 @@
-14.16.1
+14.17.6
diff --git a/WORKSPACE b/WORKSPACE
@@ -32,7 +32,7 @@ check_rules_nodejs_version(minimum_version_string = "2.2.0")
 
 # Setup the Node.js toolchain
 node_repositories(
-    node_version = "14.16.1",
+    node_version = "14.17.6",
     package_json = ["//:package.json"],
 )
 
diff --git a/integration/bazel/WORKSPACE b/integration/bazel/WORKSPACE
@@ -26,7 +26,7 @@ load("@build_bazel_rules_nodejs//:index.bzl", "node_repositories", "yarn_install
 # Setup the Node.js toolchain
 node_repositories(
     # Use same node version as root angular WORKSPACE since
-    node_version = "14.16.1",
+    node_version = "14.17.6",
     yarn_version = "1.12.1",
 )
 

Original file line number	Diff line number	Diff line change
`@@ -32,7 +32,7 @@ check_rules_nodejs_version(minimum_version_string = "2.2.0")`
`32`	`32`
`33`	`33`	`# Setup the Node.js toolchain`
`34`	`34`	`node_repositories(`
`35`		`- node_version = "14.16.1",`
	`35`	`+ node_version = "14.17.6",`
`36`	`36`	`package_json = ["//:package.json"],`
`37`	`37`	`)`
`38`	`38`
Original file line number	Diff line number	Diff line change
`@@ -26,7 +26,7 @@ load("@build_bazel_rules_nodejs//:index.bzl", "node_repositories", "yarn_install`
`26`	`26`	`# Setup the Node.js toolchain`
`27`	`27`	`node_repositories(`
`28`	`28`	`# Use same node version as root angular WORKSPACE since`
`29`		`- node_version = "14.16.1",`
	`29`	`+ node_version = "14.17.6",`
`30`	`30`	`yarn_version = "1.12.1",`
`31`	`31`	`)`
`32`	`32`