refactor: address prototype polution concern with better typing (angular#54286)

josephperrott · thePunderWoman · commit 4d29174585c0 · 2024-02-06T18:38:47.000Z
Update typing to show that a number is being used as index rather than any random string PR Close angular#54286
diff --git a/packages/misc/angular-in-memory-web-api/src/backend-service.ts b/packages/misc/angular-in-memory-web-api/src/backend-service.ts
@@ -513,7 +513,7 @@ export abstract class BackendService {
    */
   protected abstract getRequestMethod(req: any): string;
 
-  protected indexOf(collection: any[], id: number) {
+  protected indexOf(collection: any[], id: number): number {
     return collection.findIndex((item: any) => item.id === id);
   }
 

Original file line number	Diff line number	Diff line change
`@@ -513,7 +513,7 @@ export abstract class BackendService {`
`513`	`513`	`*/`
`514`	`514`	`protected abstract getRequestMethod(req: any): string;`
`515`	`515`
`516`		`- protected indexOf(collection: any[], id: number) {`
	`516`	`+ protected indexOf(collection: any[], id: number): number {`
`517`	`517`	`return collection.findIndex((item: any) => item.id === id);`
`518`	`518`	`}`
`519`	`519`