Does pandas import check in each caller file directly to avoid flaky tests.

Jianwei Xie · tensorflower-gardener · commit 936e5937220f · 2017-03-03T09:31:31.000-08:00
Change: 149118694
diff --git a/tensorflow/contrib/learn/python/learn/learn_io/pandas_io.py b/tensorflow/contrib/learn/python/learn/learn_io/pandas_io.py
@@ -19,12 +19,17 @@
 from __future__ import division
 from __future__ import print_function
 
-from tensorflow.python.estimator.inputs.pandas_import import HAS_PANDAS
 from tensorflow.python.estimator.inputs.pandas_io import pandas_input_fn  # pylint: disable=unused-import
 
-if HAS_PANDAS:
+try:
   # pylint: disable=g-import-not-at-top
   import pandas as pd
+  HAS_PANDAS = True
+except IOError:
+  # Pandas writes a temporary file during import. If it fails, don't use pandas.
+  HAS_PANDAS = False
+except ImportError:
+  HAS_PANDAS = False
 
 PANDAS_DTYPES = {
     'int8': 'int',
diff --git a/tensorflow/python/estimator/BUILD b/tensorflow/python/estimator/BUILD
@@ -163,7 +163,6 @@ py_library(
     srcs_version = "PY2AND3",
     deps = [
         ":numpy_io",
-        ":pandas_import",
         ":pandas_io",
     ],
 )
@@ -190,20 +189,11 @@ py_test(
     ],
 )
 
-py_library(
-    name = "pandas_import",
-    srcs = ["inputs/pandas_import.py"],
-    srcs_version = "PY2AND3",
-)
-
 py_library(
     name = "pandas_io",
     srcs = ["inputs/pandas_io.py"],
     srcs_version = "PY2AND3",
-    deps = [
-        ":inputs_queues",
-        ":pandas_import",
-    ],
+    deps = [":inputs_queues"],
 )
 
 py_test(
@@ -228,10 +218,7 @@ py_library(
         "inputs/queues/feeding_queue_runner.py",
     ],
     srcs_version = "PY2AND3",
-    deps = [
-        ":pandas_import",
-        "//tensorflow/python:training",
-    ],
+    deps = ["//tensorflow/python:training"],
 )
 
 py_test(
diff --git a/tensorflow/python/estimator/inputs/__init__.py b/tensorflow/python/estimator/inputs/__init__.py
@@ -19,5 +19,4 @@
 from __future__ import print_function
 
 from tensorflow.python.estimator.inputs.numpy_io import numpy_input_fn
-from tensorflow.python.estimator.inputs.pandas_import import HAS_PANDAS
 from tensorflow.python.estimator.inputs.pandas_io import pandas_input_fn
diff --git a/tensorflow/python/estimator/inputs/pandas_import.py b/tensorflow/python/estimator/inputs/pandas_import.py
diff --git a/tensorflow/python/estimator/inputs/pandas_io.py b/tensorflow/python/estimator/inputs/pandas_io.py
@@ -20,9 +20,19 @@
 from __future__ import print_function
 
 import numpy as np
-from tensorflow.python.estimator.inputs.pandas_import import HAS_PANDAS
 from tensorflow.python.estimator.inputs.queues import feeding_functions
 
+try:
+  # pylint: disable=g-import-not-at-top
+  # pylint: disable=unused-import
+  import pandas as pd
+  HAS_PANDAS = True
+except IOError:
+  # Pandas writes a temporary file during import. If it fails, don't use pandas.
+  HAS_PANDAS = False
+except ImportError:
+  HAS_PANDAS = False
+
 
 def pandas_input_fn(x,
                     y=None,
diff --git a/tensorflow/python/estimator/inputs/pandas_io_test.py b/tensorflow/python/estimator/inputs/pandas_io_test.py
@@ -21,15 +21,20 @@
 import numpy as np
 
 from tensorflow.python.estimator.inputs import pandas_io
-from tensorflow.python.estimator.inputs.pandas_import import HAS_PANDAS
 from tensorflow.python.framework import errors
 from tensorflow.python.platform import test
 from tensorflow.python.training import coordinator
 from tensorflow.python.training import queue_runner_impl
 
-if HAS_PANDAS:
+try:
   # pylint: disable=g-import-not-at-top
   import pandas as pd
+  HAS_PANDAS = True
+except IOError:
+  # Pandas writes a temporary file during import. If it fails, don't use pandas.
+  HAS_PANDAS = False
+except ImportError:
+  HAS_PANDAS = False
 
 
 class PandasIoTest(test.TestCase):
diff --git a/tensorflow/python/estimator/inputs/queues/feeding_functions.py b/tensorflow/python/estimator/inputs/queues/feeding_functions.py
@@ -22,7 +22,6 @@
 import random
 import numpy as np
 
-from tensorflow.python.estimator.inputs.pandas_import import HAS_PANDAS
 from tensorflow.python.estimator.inputs.queues import feeding_queue_runner as fqr
 from tensorflow.python.framework import dtypes
 from tensorflow.python.framework import errors
@@ -34,9 +33,15 @@
 from tensorflow.python.summary import summary
 from tensorflow.python.training import queue_runner
 
-if HAS_PANDAS:
+try:
   # pylint: disable=g-import-not-at-top
   import pandas as pd
+  HAS_PANDAS = True
+except IOError:
+  # Pandas writes a temporary file during import. If it fails, don't use pandas.
+  HAS_PANDAS = False
+except ImportError:
+  HAS_PANDAS = False
 
 
 def _get_integer_indices_for_next_batch(
diff --git a/tensorflow/python/estimator/inputs/queues/feeding_functions_test.py b/tensorflow/python/estimator/inputs/queues/feeding_functions_test.py
@@ -22,13 +22,18 @@
 
 import numpy as np
 
-from tensorflow.python.estimator.inputs.pandas_import import HAS_PANDAS
 from tensorflow.python.estimator.inputs.queues import feeding_functions as ff
 from tensorflow.python.platform import test
 
-if HAS_PANDAS:
+try:
   # pylint: disable=g-import-not-at-top
   import pandas as pd
+  HAS_PANDAS = True
+except IOError:
+  # Pandas writes a temporary file during import. If it fails, don't use pandas.
+  HAS_PANDAS = False
+except ImportError:
+  HAS_PANDAS = False
 
 
 def vals_to_list(a):
diff --git a/tensorflow/python/estimator/inputs/queues/feeding_queue_runner_test.py b/tensorflow/python/estimator/inputs/queues/feeding_queue_runner_test.py
@@ -21,16 +21,21 @@
 import numpy as np
 
 from tensorflow.python.client import session
-from tensorflow.python.estimator.inputs.pandas_import import HAS_PANDAS
 from tensorflow.python.estimator.inputs.queues import feeding_functions as ff
 from tensorflow.python.framework import ops
 from tensorflow.python.platform import test
 from tensorflow.python.training import coordinator
 from tensorflow.python.training import queue_runner_impl
 
-if HAS_PANDAS:
+try:
   # pylint: disable=g-import-not-at-top
   import pandas as pd
+  HAS_PANDAS = True
+except IOError:
+  # Pandas writes a temporary file during import. If it fails, don't use pandas.
+  HAS_PANDAS = False
+except ImportError:
+  HAS_PANDAS = False
 
 
 def get_rows(array, row_indices):
