Skip to content

Commit 90d5fec

Browse files
committed
Rename delta to deltaTime.
Minor refactoring.
1 parent 0d35973 commit 90d5fec

21 files changed

Lines changed: 48 additions & 48 deletions

src/core/EffectComposer.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -324,10 +324,10 @@ export class EffectComposer {
324324
/**
325325
* Renders all enabled passes in the order in which they were added.
326326
*
327-
* @param {Number} delta - The time between the last frame and the current one in seconds.
327+
* @param {Number} deltaTime - The time between the last frame and the current one in seconds.
328328
*/
329329

330-
render(delta) {
330+
render(deltaTime) {
331331

332332
const renderer = this.renderer;
333333
const copyPass = this.copyPass;
@@ -342,7 +342,7 @@ export class EffectComposer {
342342

343343
if(pass.enabled) {
344344

345-
pass.render(renderer, inputBuffer, outputBuffer, delta, stencilTest);
345+
pass.render(renderer, inputBuffer, outputBuffer, deltaTime, stencilTest);
346346

347347
if(pass.needsSwap) {
348348

@@ -355,7 +355,7 @@ export class EffectComposer {
355355

356356
// Preserve the unaffected pixels.
357357
state.buffers.stencil.setFunc(context.NOTEQUAL, 1, 0xffffffff);
358-
copyPass.render(renderer, inputBuffer, outputBuffer, delta, stencilTest);
358+
copyPass.render(renderer, inputBuffer, outputBuffer, deltaTime, stencilTest);
359359
state.buffers.stencil.setFunc(context.EQUAL, 1, 0xffffffff);
360360

361361
}

src/effects/BloomEffect.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -215,10 +215,10 @@ export class BloomEffect extends Effect {
215215
*
216216
* @param {WebGLRenderer} renderer - The renderer.
217217
* @param {WebGLRenderTarget} inputBuffer - A frame buffer that contains the result of the previous pass.
218-
* @param {Number} [delta] - The time between the last frame and the current one in seconds.
218+
* @param {Number} [deltaTime] - The time between the last frame and the current one in seconds.
219219
*/
220220

221-
update(renderer, inputBuffer, delta) {
221+
update(renderer, inputBuffer, deltaTime) {
222222

223223
const renderTarget = this.renderTarget;
224224

src/effects/Effect.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -145,10 +145,10 @@ export class Effect {
145145
*
146146
* @param {WebGLRenderer} renderer - The renderer.
147147
* @param {WebGLRenderTarget} inputBuffer - A frame buffer that contains the result of the previous pass.
148-
* @param {Number} [delta] - The time between the last frame and the current one in seconds.
148+
* @param {Number} [deltaTime] - The time between the last frame and the current one in seconds.
149149
*/
150150

151-
update(renderer, inputBuffer, delta) {}
151+
update(renderer, inputBuffer, deltaTime) {}
152152

153153
/**
154154
* Updates the size of this effect.

src/effects/GlitchEffect.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -284,10 +284,10 @@ export class GlitchEffect extends Effect {
284284
*
285285
* @param {WebGLRenderer} renderer - The renderer.
286286
* @param {WebGLRenderTarget} inputBuffer - A frame buffer that contains the result of the previous pass.
287-
* @param {Number} [delta] - The time between the last frame and the current one in seconds.
287+
* @param {Number} [deltaTime] - The time between the last frame and the current one in seconds.
288288
*/
289289

290-
update(renderer, inputBuffer, delta) {
290+
update(renderer, inputBuffer, deltaTime) {
291291

292292
const mode = this.mode;
293293
const breakPoint = this.breakPoint;
@@ -303,7 +303,7 @@ export class GlitchEffect extends Effect {
303303

304304
if(mode === GlitchMode.SPORADIC) {
305305

306-
time += delta;
306+
time += deltaTime;
307307
trigger = (time > breakPoint.x);
308308

309309
if(time >= (breakPoint.x + breakPoint.y)) {

src/effects/GodRaysEffect.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -370,10 +370,10 @@ export class GodRaysEffect extends Effect {
370370
*
371371
* @param {WebGLRenderer} renderer - The renderer.
372372
* @param {WebGLRenderTarget} inputBuffer - A frame buffer that contains the result of the previous pass.
373-
* @param {Number} [delta] - The time between the last frame and the current one in seconds.
373+
* @param {Number} [deltaTime] - The time between the last frame and the current one in seconds.
374374
*/
375375

376-
update(renderer, inputBuffer, delta) {
376+
update(renderer, inputBuffer, deltaTime) {
377377

378378
const scene = this.scene;
379379
const lightSource = this.lightSource;

src/effects/OutlineEffect.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -554,10 +554,10 @@ export class OutlineEffect extends Effect {
554554
*
555555
* @param {WebGLRenderer} renderer - The renderer.
556556
* @param {WebGLRenderTarget} inputBuffer - A frame buffer that contains the result of the previous pass.
557-
* @param {Number} [delta] - The time between the last frame and the current one in seconds.
557+
* @param {Number} [deltaTime] - The time between the last frame and the current one in seconds.
558558
*/
559559

560-
update(renderer, inputBuffer, delta) {
560+
update(renderer, inputBuffer, deltaTime) {
561561

562562
const mainScene = this.mainScene;
563563
const mainCamera = this.mainCamera;
@@ -574,7 +574,7 @@ export class OutlineEffect extends Effect {
574574
if(this.pulseSpeed > 0.0) {
575575

576576
pulse.value = 0.625 + Math.cos(this.time * this.pulseSpeed * 10.0) * 0.375;
577-
this.time += delta;
577+
this.time += deltaTime;
578578

579579
}
580580

src/effects/SMAAEffect.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -177,10 +177,10 @@ export class SMAAEffect extends Effect {
177177
*
178178
* @param {WebGLRenderer} renderer - The renderer.
179179
* @param {WebGLRenderTarget} inputBuffer - A frame buffer that contains the result of the previous pass.
180-
* @param {Number} [delta] - The time between the last frame and the current one in seconds.
180+
* @param {Number} [deltaTime] - The time between the last frame and the current one in seconds.
181181
*/
182182

183-
update(renderer, inputBuffer, delta) {
183+
update(renderer, inputBuffer, deltaTime) {
184184

185185
this.clearPass.render(renderer, this.renderTargetColorEdges);
186186
this.colorEdgesPass.render(renderer, inputBuffer, this.renderTargetColorEdges);

src/effects/ToneMappingEffect.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -265,10 +265,10 @@ export class ToneMappingEffect extends Effect {
265265
*
266266
* @param {WebGLRenderer} renderer - The renderer.
267267
* @param {WebGLRenderTarget} inputBuffer - A frame buffer that contains the result of the previous pass.
268-
* @param {Number} [delta] - The time between the last frame and the current one in seconds.
268+
* @param {Number} [deltaTime] - The time between the last frame and the current one in seconds.
269269
*/
270270

271-
update(renderer, inputBuffer, delta) {
271+
update(renderer, inputBuffer, deltaTime) {
272272

273273
if(this.adaptive) {
274274

@@ -279,7 +279,7 @@ export class ToneMappingEffect extends Effect {
279279
const uniforms = this.adaptiveLuminancePass.getFullscreenMaterial().uniforms;
280280
uniforms.previousLuminanceBuffer.value = this.renderTargetPrevious.texture;
281281
uniforms.currentLuminanceBuffer.value = this.renderTargetLuminance.texture;
282-
uniforms.delta.value = delta;
282+
uniforms.deltaTime.value = deltaTime;
283283
this.adaptiveLuminancePass.render(renderer, null, this.renderTargetAdapted);
284284

285285
// Save the adapted luminance for the next frame.

src/materials/AdaptiveLuminanceMaterial.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ export class AdaptiveLuminanceMaterial extends ShaderMaterial {
3030
previousLuminanceBuffer: new Uniform(null),
3131
currentLuminanceBuffer: new Uniform(null),
3232
minLuminance: new Uniform(0.01),
33-
delta: new Uniform(0.0),
33+
deltaTime: new Uniform(0.0),
3434
tau: new Uniform(1.0)
3535

3636
},

src/materials/glsl/adaptive-luminance/shader.frag

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
uniform sampler2D previousLuminanceBuffer;
22
uniform sampler2D currentLuminanceBuffer;
33
uniform float minLuminance;
4-
uniform float delta;
4+
uniform float deltaTime;
55
uniform float tau;
66

77
varying vec2 vUv;
@@ -15,7 +15,7 @@ void main() {
1515
currentLuminance = max(minLuminance, currentLuminance);
1616

1717
// Adapt the luminance using Pattanaik's technique.
18-
float adaptedLum = previousLuminance + (currentLuminance - previousLuminance) * (1.0 - exp(-delta * tau));
18+
float adaptedLum = previousLuminance + (currentLuminance - previousLuminance) * (1.0 - exp(-deltaTime * tau));
1919

2020
gl_FragColor.r = adaptedLum;
2121

0 commit comments

Comments
 (0)