ARM: sa11x0/pxa: acquire timer rate from the clock rate

rjarzmik · rjarzmik · commit f4e14edf2566 · 2016-10-18T09:12:36.000+02:00
As both pxa and sa1100 provide a clock to the timer, the rate can be
inferred from the clock rather than hard encoded in a functional call.

This patch changes the pxa timer to have a mandatory clock which is used
as the timer rate.

Signed-off-by: Robert Jarzmik &lt;robert.jarzmik@free.fr&gt;
Acked-by: Daniel Lezcano &lt;daniel.lezcano@linaro.org&gt;
Acked-by: Russell King &lt;rmk+kernel@armlinux.org.uk&gt;
diff --git a/arch/arm/mach-pxa/generic.c b/arch/arm/mach-pxa/generic.c
@@ -69,8 +69,7 @@ void __init pxa_timer_init(void)
 		pxa27x_clocks_init();
 	if (cpu_is_pxa3xx())
 		pxa3xx_clocks_init();
-	pxa_timer_nodt_init(IRQ_OST0, io_p2v(0x40a00000),
-			    get_clock_tick_rate());
+	pxa_timer_nodt_init(IRQ_OST0, io_p2v(0x40a00000));
 }
 
 /*
diff --git a/arch/arm/mach-sa1100/generic.c b/arch/arm/mach-sa1100/generic.c
@@ -378,7 +378,7 @@ void __init sa1100_map_io(void)
 
 void __init sa1100_timer_init(void)
 {
-	pxa_timer_nodt_init(IRQ_OST0, io_p2v(0x90000000), 3686400);
+	pxa_timer_nodt_init(IRQ_OST0, io_p2v(0x90000000));
 }
 
 static struct resource irq_resource =
diff --git a/drivers/clocksource/pxa_timer.c b/drivers/clocksource/pxa_timer.c
@@ -220,17 +220,16 @@ CLOCKSOURCE_OF_DECLARE(pxa_timer, "marvell,pxa-timer", pxa_timer_dt_init);
 /*
  * Legacy timer init for non device-tree boards.
  */
-void __init pxa_timer_nodt_init(int irq, void __iomem *base,
-	unsigned long clock_tick_rate)
+void __init pxa_timer_nodt_init(int irq, void __iomem *base)
 {
 	struct clk *clk;
 
 	timer_base = base;
 	clk = clk_get(NULL, "OSTIMER0");
-	if (clk && !IS_ERR(clk))
+	if (clk && !IS_ERR(clk)) {
 		clk_prepare_enable(clk);
-	else
+		pxa_timer_common_init(irq, clk_get_rate(clk));
+	} else {
 		pr_crit("%s: unable to get clk\n", __func__);
-
-	pxa_timer_common_init(irq, clock_tick_rate);
+	}
 }
diff --git a/include/clocksource/pxa.h b/include/clocksource/pxa.h
@@ -12,7 +12,6 @@
 #ifndef _CLOCKSOURCE_PXA_H
 #define _CLOCKSOURCE_PXA_H
 
-extern void pxa_timer_nodt_init(int irq, void __iomem *base,
-			   unsigned long clock_tick_rate);
+extern void pxa_timer_nodt_init(int irq, void __iomem *base);
 
 #endif

Original file line number	Diff line number	Diff line change
`@@ -69,8 +69,7 @@ void __init pxa_timer_init(void)`
`69`	`69`	`pxa27x_clocks_init();`
`70`	`70`	`if (cpu_is_pxa3xx())`
`71`	`71`	`pxa3xx_clocks_init();`
`72`		`- pxa_timer_nodt_init(IRQ_OST0, io_p2v(0x40a00000),`
`73`		`- get_clock_tick_rate());`
	`72`	`+ pxa_timer_nodt_init(IRQ_OST0, io_p2v(0x40a00000));`
`74`	`73`	`}`
`75`	`74`
`76`	`75`	`/*`
Original file line number	Diff line number	Diff line change
`@@ -378,7 +378,7 @@ void __init sa1100_map_io(void)`
`378`	`378`
`379`	`379`	`void __init sa1100_timer_init(void)`
`380`	`380`	`{`
`381`		`- pxa_timer_nodt_init(IRQ_OST0, io_p2v(0x90000000), 3686400);`
	`381`	`+ pxa_timer_nodt_init(IRQ_OST0, io_p2v(0x90000000));`
`382`	`382`	`}`
`383`	`383`
`384`	`384`	`static struct resource irq_resource =`