Skip to content

Commit b5dceda

Browse files
anupbrcmVinod Koul
authored andcommitted
lib/raid6: Add log-of-2 table for RAID6 HW requiring disk position
The raid6_gfexp table represents {2}^n values for 0 <= n < 256. The Linux async_tx framework pass values from raid6_gfexp as coefficients for each source to prep_dma_pq() callback of DMA channel with PQ capability. This creates problem for RAID6 offload engines (such as Broadcom SBA) which take disk position (i.e. log of {2}) instead of multiplicative cofficients from raid6_gfexp table. This patch adds raid6_gflog table having log-of-2 value for any given x such that 0 <= x < 256. For any given disk coefficient x, the corresponding disk position is given by raid6_gflog[x]. The RAID6 offload engine driver can use this newly added raid6_gflog table to get disk position from multiplicative coefficient. Signed-off-by: Anup Patel <anup.patel@broadcom.com> Reviewed-by: Scott Branden <scott.branden@broadcom.com> Reviewed-by: Ray Jui <ray.jui@broadcom.com> Acked-by: Shaohua Li <shli@fb.com> Signed-off-by: Vinod Koul <vinod.koul@intel.com>
1 parent 2ea659a commit b5dceda

File tree

2 files changed

+21
-0
lines changed

2 files changed

+21
-0
lines changed

include/linux/raid/pq.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -142,6 +142,7 @@ int raid6_select_algo(void);
142142
extern const u8 raid6_gfmul[256][256] __attribute__((aligned(256)));
143143
extern const u8 raid6_vgfmul[256][32] __attribute__((aligned(256)));
144144
extern const u8 raid6_gfexp[256] __attribute__((aligned(256)));
145+
extern const u8 raid6_gflog[256] __attribute__((aligned(256)));
145146
extern const u8 raid6_gfinv[256] __attribute__((aligned(256)));
146147
extern const u8 raid6_gfexi[256] __attribute__((aligned(256)));
147148

lib/raid6/mktables.c

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -125,6 +125,26 @@ int main(int argc, char *argv[])
125125
printf("EXPORT_SYMBOL(raid6_gfexp);\n");
126126
printf("#endif\n");
127127

128+
/* Compute log-of-2 table */
129+
printf("\nconst u8 __attribute__((aligned(256)))\n"
130+
"raid6_gflog[256] =\n" "{\n");
131+
for (i = 0; i < 256; i += 8) {
132+
printf("\t");
133+
for (j = 0; j < 8; j++) {
134+
v = 255;
135+
for (k = 0; k < 256; k++)
136+
if (exptbl[k] == (i + j)) {
137+
v = k;
138+
break;
139+
}
140+
printf("0x%02x,%c", v, (j == 7) ? '\n' : ' ');
141+
}
142+
}
143+
printf("};\n");
144+
printf("#ifdef __KERNEL__\n");
145+
printf("EXPORT_SYMBOL(raid6_gflog);\n");
146+
printf("#endif\n");
147+
128148
/* Compute inverse table x^-1 == x^254 */
129149
printf("\nconst u8 __attribute__((aligned(256)))\n"
130150
"raid6_gfinv[256] =\n" "{\n");

0 commit comments

Comments
 (0)