[compute] fix: always use a new uuid (GoogleCloudPlatform#3449)

Takashi Matsuo · web-flow · commit 89ecd244b65c · 2020-04-21T11:02:23.000-07:00
fixes GoogleCloudPlatform#2883
diff --git a/compute/api/create_instance_test.py b/compute/api/create_instance_test.py
@@ -14,27 +14,27 @@
 import os
 import uuid
 
-from flaky import flaky
+import pytest
 
 from create_instance import main
 
 PROJECT = os.environ['GCLOUD_PROJECT']
 BUCKET = os.environ['CLOUD_STORAGE_BUCKET']
-INSTANCE_NAME = 'test-instance-' + str(uuid.uuid4())
 
 
-@flaky
+@pytest.mark.flaky(max_runs=3, min_passes=1)
 def test_main(capsys):
+    instance_name = 'test-instance-{}'.format(uuid.uuid4())
     main(
         PROJECT,
         BUCKET,
         'us-central1-f',
-        INSTANCE_NAME,
+        instance_name,
         wait=False)
 
     out, _ = capsys.readouterr()
 
     assert "Instances in project" in out
     assert "zone us-central1-f" in out
-    assert INSTANCE_NAME in out
+    assert instance_name in out
     assert "Deleting instance" in out
