Skip to content

Commit fa30e55

Browse files
yfei-zvelo
authored andcommitted
Copy default config if present before per request timeouts setting in (OpenFeign#734)
ApacheHttpClient
1 parent 248bb9a commit fa30e55

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

httpclient/src/main/java/feign/httpclient/ApacheHttpClient.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@
2020
import org.apache.http.StatusLine;
2121
import org.apache.http.client.HttpClient;
2222
import org.apache.http.client.config.RequestConfig;
23+
import org.apache.http.client.methods.Configurable;
2324
import org.apache.http.client.methods.HttpUriRequest;
2425
import org.apache.http.client.methods.RequestBuilder;
2526
import org.apache.http.client.utils.URIBuilder;
@@ -89,8 +90,7 @@ HttpUriRequest toHttpUriRequest(Request request, Request.Options options)
8990
RequestBuilder requestBuilder = RequestBuilder.create(request.method());
9091

9192
// per request timeouts
92-
RequestConfig requestConfig = RequestConfig
93-
.custom()
93+
RequestConfig requestConfig = (client instanceof Configurable ? RequestConfig.copy(((Configurable) client).getConfig()) : RequestConfig.custom())
9494
.setConnectTimeout(options.connectTimeoutMillis())
9595
.setSocketTimeout(options.readTimeoutMillis())
9696
.build();

0 commit comments

Comments
 (0)