Skip to content

Commit cbf073b

Browse files
author
Jon Wayne Parrott
authored
Re-enable pylint in info-only mode for all packages (googleapis#3519)
1 parent 27dcf5a commit cbf073b

File tree

36 files changed

+588
-55
lines changed

36 files changed

+588
-55
lines changed

‎bigquery/nox.py‎

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -66,15 +66,22 @@ def system_tests(session, python_version):
6666

6767
@nox.session
6868
def lint(session):
69-
"""Run flake8.
69+
"""Run linters.
7070
71-
Returns a failure if flake8 finds linting errors or sufficiently
71+
Returns a failure if the linters find linting errors or sufficiently
7272
serious code quality issues.
7373
"""
7474
session.interpreter = 'python3.6'
75-
session.install('flake8', *LOCAL_DEPS)
75+
session.install('flake8', 'pylint', 'gcp-devrel-py-tools', *LOCAL_DEPS)
7676
session.install('.')
7777
session.run('flake8', 'google/cloud/bigquery')
78+
session.run(
79+
'gcp-devrel-py-tools', 'run-pylint',
80+
'--config', 'pylint.config.py',
81+
'--library-filesets', 'google',
82+
'--test-filesets', 'tests',
83+
# Temporarily allow this to fail.
84+
success_codes=range(0, 100))
7885

7986

8087
@nox.session

‎bigquery/pylint.config.py‎

Lines changed: 25 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,25 @@
1+
# Copyright 2017 Google Inc.
2+
#
3+
# Licensed under the Apache License, Version 2.0 (the "License");
4+
# you may not use this file except in compliance with the License.
5+
# You may obtain a copy of the License at
6+
#
7+
# http://www.apache.org/licenses/LICENSE-2.0
8+
#
9+
# Unless required by applicable law or agreed to in writing, software
10+
# distributed under the License is distributed on an "AS IS" BASIS,
11+
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12+
# See the License for the specific language governing permissions and
13+
# limitations under the License.
14+
15+
"""This module is used to configure gcp-devrel-py-tools run-pylint."""
16+
17+
# Library configuration
18+
19+
# library_additions = {}
20+
# library_replacements = {}
21+
22+
# Test configuration
23+
24+
# test_additions = copy.deepcopy(library_additions)
25+
# test_replacements = copy.deepcopy(library_replacements)

‎bigtable/nox.py‎

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -65,15 +65,22 @@ def system_tests(session, python_version):
6565

6666
@nox.session
6767
def lint(session):
68-
"""Run flake8.
68+
"""Run linters.
6969
70-
Returns a failure if flake8 finds linting errors or sufficiently
70+
Returns a failure if the linters find linting errors or sufficiently
7171
serious code quality issues.
7272
"""
7373
session.interpreter = 'python3.6'
74-
session.install('flake8', *LOCAL_DEPS)
74+
session.install('flake8', 'pylint', 'gcp-devrel-py-tools', *LOCAL_DEPS)
7575
session.install('.')
7676
session.run('flake8', 'google/cloud/bigtable')
77+
session.run(
78+
'gcp-devrel-py-tools', 'run-pylint',
79+
'--config', 'pylint.config.py',
80+
'--library-filesets', 'google',
81+
'--test-filesets', 'tests',
82+
# Temporarily allow this to fail.
83+
success_codes=range(0, 100))
7784

7885

7986
@nox.session

‎bigtable/pylint.config.py‎

Lines changed: 25 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,25 @@
1+
# Copyright 2017 Google Inc.
2+
#
3+
# Licensed under the Apache License, Version 2.0 (the "License");
4+
# you may not use this file except in compliance with the License.
5+
# You may obtain a copy of the License at
6+
#
7+
# http://www.apache.org/licenses/LICENSE-2.0
8+
#
9+
# Unless required by applicable law or agreed to in writing, software
10+
# distributed under the License is distributed on an "AS IS" BASIS,
11+
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12+
# See the License for the specific language governing permissions and
13+
# limitations under the License.
14+
15+
"""This module is used to configure gcp-devrel-py-tools run-pylint."""
16+
17+
# Library configuration
18+
19+
# library_additions = {}
20+
# library_replacements = {}
21+
22+
# Test configuration
23+
24+
# test_additions = copy.deepcopy(library_additions)
25+
# test_replacements = copy.deepcopy(library_replacements)

‎datastore/nox.py‎

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -90,15 +90,22 @@ def doctests(session):
9090

9191
@nox.session
9292
def lint(session):
93-
"""Run flake8.
93+
"""Run linters.
9494
95-
Returns a failure if flake8 finds linting errors or sufficiently
95+
Returns a failure if the linters find linting errors or sufficiently
9696
serious code quality issues.
9797
"""
9898
session.interpreter = 'python3.6'
99-
session.install('flake8', *LOCAL_DEPS)
99+
session.install('flake8', 'pylint', 'gcp-devrel-py-tools', *LOCAL_DEPS)
100100
session.install('.')
101101
session.run('flake8', 'google/cloud/datastore')
102+
session.run(
103+
'gcp-devrel-py-tools', 'run-pylint',
104+
'--config', 'pylint.config.py',
105+
'--library-filesets', 'google',
106+
'--test-filesets', 'tests',
107+
# Temporarily allow this to fail.
108+
success_codes=range(0, 100))
102109

103110

104111
@nox.session

‎datastore/pylint.config.py‎

Lines changed: 25 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,25 @@
1+
# Copyright 2017 Google Inc.
2+
#
3+
# Licensed under the Apache License, Version 2.0 (the "License");
4+
# you may not use this file except in compliance with the License.
5+
# You may obtain a copy of the License at
6+
#
7+
# http://www.apache.org/licenses/LICENSE-2.0
8+
#
9+
# Unless required by applicable law or agreed to in writing, software
10+
# distributed under the License is distributed on an "AS IS" BASIS,
11+
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12+
# See the License for the specific language governing permissions and
13+
# limitations under the License.
14+
15+
"""This module is used to configure gcp-devrel-py-tools run-pylint."""
16+
17+
# Library configuration
18+
19+
# library_additions = {}
20+
# library_replacements = {}
21+
22+
# Test configuration
23+
24+
# test_additions = copy.deepcopy(library_additions)
25+
# test_replacements = copy.deepcopy(library_replacements)

‎dns/nox.py‎

Lines changed: 11 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -44,15 +44,22 @@ def unit_tests(session, python_version):
4444

4545
@nox.session
4646
def lint(session):
47-
"""Run flake8.
47+
"""Run linters.
4848
49-
Returns a failure if flake8 finds linting errors or sufficiently
49+
Returns a failure if the linters find linting errors or sufficiently
5050
serious code quality issues.
5151
"""
5252
session.interpreter = 'python3.6'
53-
session.install('flake8', *LOCAL_DEPS)
53+
session.install('flake8', 'pylint', 'gcp-devrel-py-tools', *LOCAL_DEPS)
5454
session.install('.')
55-
session.run('flake8', 'google/cloud/dns')
55+
session.run('flake8', 'google/cloud/datastore')
56+
session.run(
57+
'gcp-devrel-py-tools', 'run-pylint',
58+
'--config', 'pylint.config.py',
59+
'--library-filesets', 'google',
60+
'--test-filesets', 'tests',
61+
# Temporarily allow this to fail.
62+
success_codes=range(0, 100))
5663

5764

5865
@nox.session

‎dns/pylint.config.py‎

Lines changed: 25 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,25 @@
1+
# Copyright 2017 Google Inc.
2+
#
3+
# Licensed under the Apache License, Version 2.0 (the "License");
4+
# you may not use this file except in compliance with the License.
5+
# You may obtain a copy of the License at
6+
#
7+
# http://www.apache.org/licenses/LICENSE-2.0
8+
#
9+
# Unless required by applicable law or agreed to in writing, software
10+
# distributed under the License is distributed on an "AS IS" BASIS,
11+
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12+
# See the License for the specific language governing permissions and
13+
# limitations under the License.
14+
15+
"""This module is used to configure gcp-devrel-py-tools run-pylint."""
16+
17+
# Library configuration
18+
19+
# library_additions = {}
20+
# library_replacements = {}
21+
22+
# Test configuration
23+
24+
# test_additions = copy.deepcopy(library_additions)
25+
# test_replacements = copy.deepcopy(library_replacements)

‎error_reporting/nox.py‎

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -44,15 +44,22 @@ def unit_tests(session, python_version):
4444

4545
@nox.session
4646
def lint(session):
47-
"""Run flake8.
47+
"""Run linters.
4848
49-
Returns a failure if flake8 finds linting errors or sufficiently
49+
Returns a failure if the linters find linting errors or sufficiently
5050
serious code quality issues.
5151
"""
5252
session.interpreter = 'python3.6'
53-
session.install('flake8', *LOCAL_DEPS)
53+
session.install('flake8', 'pylint', 'gcp-devrel-py-tools', *LOCAL_DEPS)
5454
session.install('.')
5555
session.run('flake8', 'google/cloud/error_reporting')
56+
session.run(
57+
'gcp-devrel-py-tools', 'run-pylint',
58+
'--config', 'pylint.config.py',
59+
'--library-filesets', 'google',
60+
'--test-filesets', 'tests',
61+
# Temporarily allow this to fail.
62+
success_codes=range(0, 100))
5663

5764

5865
@nox.session

‎error_reporting/pylint.config.py‎

Lines changed: 25 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,25 @@
1+
# Copyright 2017 Google Inc.
2+
#
3+
# Licensed under the Apache License, Version 2.0 (the "License");
4+
# you may not use this file except in compliance with the License.
5+
# You may obtain a copy of the License at
6+
#
7+
# http://www.apache.org/licenses/LICENSE-2.0
8+
#
9+
# Unless required by applicable law or agreed to in writing, software
10+
# distributed under the License is distributed on an "AS IS" BASIS,
11+
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12+
# See the License for the specific language governing permissions and
13+
# limitations under the License.
14+
15+
"""This module is used to configure gcp-devrel-py-tools run-pylint."""
16+
17+
# Library configuration
18+
19+
# library_additions = {}
20+
# library_replacements = {}
21+
22+
# Test configuration
23+
24+
# test_additions = copy.deepcopy(library_additions)
25+
# test_replacements = copy.deepcopy(library_replacements)

0 commit comments

Comments
 (0)