Skip to content

Commit d783f3e

Browse files
deepak1556Benjamin Paserorzhao271
authored
chore: update to electron 16 (microsoft#137241)
* chore: bump electron@15.3.0 * chore: bump node@16.x * chore: enable render process reuse * Revert "watcher - use `type` property for crash reporter location" This reverts commit bfa488d. * Revert "watcher - enable crash reports on linux (microsoft#136264)" This reverts commit af26148. * chore: enable crashpad on linux * chore: bump electron@15.3.1 * chore: update api changes * chore: bump @vscode/sqlite3@5.0.3 * spec: skip non-context aware module unittests * chore: fix perf hook integration with node environment * fix: adopt fs api changes * chore: fix integration tests * chore: bump electron@15.3.2 * chore: bump electron@16.0.0 * temp(macOS): kill test instances in OSS * Revert "temp(macOS): kill test instances in OSS" This reverts commit b0d796c. * chore: update chromium version for clang downloader * some 💄 changes * align with changes * adopt more fs.rm * 💄 * chore: bump @vscode/sqlite3@5.0.4 * fix layers check to account for duplicated types from node.js * update todo for type casts * smoke - fix compile issue * chore: update module cache * watcher - fix unhandled rejection (fix microsoft#137416) * ci: update node version * enable stack dumping * update electron types to 16.x * chore: bump @vscode/sqlite3@5.0.5 Refs microsoft#137496 * fix layer issue * add `AbortSignal` to core types * chore: update linux compile flags Refs electron/electron@797723e * ci: fix linux build * ci: update github ci cache * ci: fix remote build in github ci * ci: better fix for remote build * chore: bump azure cache * chore: fix merge conflict * :chore: update to electron@16.0.2 * chore: bump @vscode/sqlite3@5.0.7 * ci: update to gcc-4.9 for remote Refs microsoft#137659 * ci: switch to buster for linux arm Refs microsoft#137927 * ci: fix build on linux arm64 * ci: fix arm client compiler toolchain Refs microsoft#137927 * chore: bump electron@16.0.3 * ci: fix compile flags for the c toolchain * chore: bump electron@16.0.4 * Add experimental dark mode flag (microsoft#139109) * Add experimental dark mode flag * Apply PR feedback * chore: bump electron@16.0.6 * chore: bump electron@16.0.7 Fixes microsoft#138792 Fixes microsoft#139300 * chore: experimental highlight API * smoke - fix compile issue * FIXME: custom ELECTRON_RUN_AS_NODE with node worker * Revert "chore: bump electron@16.0.7" This reverts commit 5fd01cf. * Revert "Revert "chore: bump electron@16.0.7"" This reverts commit a7f1b73. * chore: fix github linux workflow * chore: address review feedback * chore: bump electron@16.0.8 * ci: revert to stretch distro for linux arm Refs microsoft#137927 * ci: force build * chore: update yarn.lock * address feedback * Revert "FIXME: custom ELECTRON_RUN_AS_NODE with node worker" This reverts commit 7b48fa3. * ci: fix remote folder build * chore: fix github linux ci * 🆙 `versionSpec` Co-authored-by: Benjamin Pasero <benjamin.pasero@microsoft.com> Co-authored-by: Raymond Zhao <raymondzhao@microsoft.com>
1 parent 501081d commit d783f3e

8 files changed

Lines changed: 17 additions & 21 deletions

File tree

‎automation/package.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@
2929
"devDependencies": {
3030
"@types/mkdirp": "^1.0.1",
3131
"@types/ncp": "2.0.1",
32-
"@types/node": "14.x",
32+
"@types/node": "16.x",
3333
"@types/tmp": "0.2.2",
3434
"cpx2": "3.0.0",
3535
"npm-run-all": "^4.1.5",

‎automation/src/code.ts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -206,7 +206,7 @@ export class Code {
206206
this.logger.log('Smoke test exit call did not terminate process after 10s, forcefully exiting the application...');
207207

208208
// no need to await since we're polling for the process to die anyways
209-
treekill(this.mainProcess.pid, err => {
209+
treekill(this.mainProcess.pid!, err => {
210210
this.logger.log('Failed to kill Electron process tree:', err?.message);
211211
});
212212
}
@@ -217,7 +217,7 @@ export class Code {
217217
}
218218

219219
try {
220-
process.kill(this.mainProcess.pid, 0); // throws an exception if the process doesn't exist anymore.
220+
process.kill(this.mainProcess.pid!, 0); // throws an exception if the process doesn't exist anymore.
221221
await new Promise(resolve => setTimeout(resolve, 500));
222222
} catch (error) {
223223
done = true;

‎automation/yarn.lock‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -21,10 +21,10 @@
2121
resolved "https://registry.yarnpkg.com/@types/node/-/node-12.7.1.tgz#3b5c3a26393c19b400844ac422bd0f631a94d69d"
2222
integrity sha512-aK9jxMypeSrhiYofWWBf/T7O+KwaiAHzM4sveCdWPn71lzUSMimRnKzhXDKfKwV1kWoBo2P1aGgaIYGLf9/ljw==
2323

24-
"@types/node@14.x":
25-
version "14.14.43"
26-
resolved "https://registry.yarnpkg.com/@types/node/-/node-14.14.43.tgz#26bcbb0595b305400e8ceaf9a127a7f905ae49c8"
27-
integrity sha512-3pwDJjp1PWacPTpH0LcfhgjvurQvrZFBrC6xxjaUEZ7ifUtT32jtjPxEMMblpqd2Mvx+k8haqQJLQxolyGN/cQ==
24+
"@types/node@16.x":
25+
version "16.11.6"
26+
resolved "https://registry.yarnpkg.com/@types/node/-/node-16.11.6.tgz#6bef7a2a0ad684cf6e90fcfe31cecabd9ce0a3ae"
27+
integrity sha512-ua7PgUoeQFjmWPcoo9khiPum3Pd60k4/2ZGXt18sm2Slk0W0xZTqt5Y0Ny1NyBiN1EVQ/+FaF9NcY4Qe6rwk5w==
2828

2929
"@types/tmp@0.2.2":
3030
version "0.2.2"

‎integration/browser/package.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
},
99
"devDependencies": {
1010
"@types/mkdirp": "^1.0.1",
11-
"@types/node": "14.x",
11+
"@types/node": "16.x",
1212
"@types/optimist": "0.0.29",
1313
"@types/rimraf": "^2.0.4",
1414
"@types/tmp": "0.1.0",

‎integration/browser/yarn.lock‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -33,10 +33,10 @@
3333
resolved "https://registry.yarnpkg.com/@types/node/-/node-13.7.0.tgz#b417deda18cf8400f278733499ad5547ed1abec4"
3434
integrity sha512-GnZbirvmqZUzMgkFn70c74OQpTTUcCzlhQliTzYjQMqg+hVKcDnxdL19Ne3UdYzdMA/+W3eb646FWn/ZaT1NfQ==
3535

36-
"@types/node@14.x":
37-
version "14.14.43"
38-
resolved "https://registry.yarnpkg.com/@types/node/-/node-14.14.43.tgz#26bcbb0595b305400e8ceaf9a127a7f905ae49c8"
39-
integrity sha512-3pwDJjp1PWacPTpH0LcfhgjvurQvrZFBrC6xxjaUEZ7ifUtT32jtjPxEMMblpqd2Mvx+k8haqQJLQxolyGN/cQ==
36+
"@types/node@16.x":
37+
version "16.11.6"
38+
resolved "https://registry.yarnpkg.com/@types/node/-/node-16.11.6.tgz#6bef7a2a0ad684cf6e90fcfe31cecabd9ce0a3ae"
39+
integrity sha512-ua7PgUoeQFjmWPcoo9khiPum3Pd60k4/2ZGXt18sm2Slk0W0xZTqt5Y0Ny1NyBiN1EVQ/+FaF9NcY4Qe6rwk5w==
4040

4141
"@types/optimist@0.0.29":
4242
version "0.0.29"

‎smoke/package.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
"@types/mkdirp": "^1.0.1",
2222
"@types/mocha": "^8.2.0",
2323
"@types/ncp": "2.0.1",
24-
"@types/node": "14.x",
24+
"@types/node": "16.x",
2525
"@types/node-fetch": "^2.5.10",
2626
"@types/rimraf": "3.0.2",
2727
"npm-run-all": "^4.1.5",

‎smoke/yarn.lock‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -58,10 +58,10 @@
5858
resolved "https://registry.yarnpkg.com/@types/node/-/node-13.11.0.tgz#390ea202539c61c8fa6ba4428b57e05bc36dc47b"
5959
integrity sha512-uM4mnmsIIPK/yeO+42F2RQhGUIs39K2RFmugcJANppXe6J1nvH87PvzPZYpza7Xhhs8Yn9yIAVdLZ84z61+0xQ==
6060

61-
"@types/node@14.x":
62-
version "14.14.43"
63-
resolved "https://registry.yarnpkg.com/@types/node/-/node-14.14.43.tgz#26bcbb0595b305400e8ceaf9a127a7f905ae49c8"
64-
integrity sha512-3pwDJjp1PWacPTpH0LcfhgjvurQvrZFBrC6xxjaUEZ7ifUtT32jtjPxEMMblpqd2Mvx+k8haqQJLQxolyGN/cQ==
61+
"@types/node@16.x":
62+
version "16.11.6"
63+
resolved "https://registry.yarnpkg.com/@types/node/-/node-16.11.6.tgz#6bef7a2a0ad684cf6e90fcfe31cecabd9ce0a3ae"
64+
integrity sha512-ua7PgUoeQFjmWPcoo9khiPum3Pd60k4/2ZGXt18sm2Slk0W0xZTqt5Y0Ny1NyBiN1EVQ/+FaF9NcY4Qe6rwk5w==
6565

6666
"@types/rimraf@3.0.2":
6767
version "3.0.2"

‎unit/electron/index.js‎

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -20,10 +20,6 @@ const net = require('net');
2020
const createStatsCollector = require('mocha/lib/stats-collector');
2121
const { applyReporter, importMochaReporter } = require('../reporter');
2222

23-
// Disable render process reuse, we still have
24-
// non-context aware native modules in the renderer.
25-
app.allowRendererProcessReuse = false;
26-
2723
const optimist = require('optimist')
2824
.describe('grep', 'only run tests matching <pattern>').alias('grep', 'g').alias('grep', 'f').string('grep')
2925
.describe('run', 'only run tests from <file>').string('run')

0 commit comments

Comments
 (0)