Enable type checking in more js build files

mjbvz · mjbvz · commit d6d2122c5080 · 2022-02-28T14:41:26.000-08:00
diff --git a/build/builtin/browser-main.js b/build/builtin/browser-main.js
@@ -2,6 +2,7 @@
  *  Copyright (c) Microsoft Corporation. All rights reserved.
  *  Licensed under the MIT License. See License.txt in the project root for license information.
  *--------------------------------------------------------------------------------------------*/
+//@ts-check
 
 const fs = require('fs');
 const path = require('path');
diff --git a/build/builtin/main.js b/build/builtin/main.js
@@ -2,6 +2,7 @@
  *  Copyright (c) Microsoft Corporation. All rights reserved.
  *  Licensed under the MIT License. See License.txt in the project root for license information.
  *--------------------------------------------------------------------------------------------*/
+// @ts-check
 
 const { app, BrowserWindow, ipcMain, dialog } = require('electron');
 const url = require('url');
diff --git a/build/npm/postinstall.js b/build/npm/postinstall.js
@@ -2,7 +2,7 @@
  *  Copyright (c) Microsoft Corporation. All rights reserved.
  *  Licensed under the MIT License. See License.txt in the project root for license information.
  *--------------------------------------------------------------------------------------------*/
-
+//@ts-check
 const cp = require('child_process');
 const path = require('path');
 const fs = require('fs');
diff --git a/build/npm/preinstall.js b/build/npm/preinstall.js
@@ -2,7 +2,7 @@
  *  Copyright (c) Microsoft Corporation. All rights reserved.
  *  Licensed under the MIT License. See License.txt in the project root for license information.
  *--------------------------------------------------------------------------------------------*/
-
+//@ts-check
 let err = false;
 
 const nodeVersion = /^(\d+)\.(\d+)\.(\d+)/.exec(process.versions.node);
@@ -88,12 +88,11 @@ function hasSupportedVisualStudioVersion() {
 
 function installHeaders() {
 	const yarn = 'yarn.cmd';
-	const opts = {
+	const yarnResult = cp.spawnSync(yarn, ['install'], {
 		env: process.env,
 		cwd: path.join(__dirname, 'gyp'),
 		stdio: 'inherit'
-	};
-	const yarnResult = cp.spawnSync(yarn, ['install'], opts);
+	});
 	if (yarnResult.error || yarnResult.status !== 0) {
 		console.error(`Installing node-gyp failed`);
 		err = true;
diff --git a/build/npm/update-all-grammars.js b/build/npm/update-all-grammars.js
@@ -2,7 +2,7 @@
  *  Copyright (c) Microsoft Corporation. All rights reserved.
  *  Licensed under the MIT License. See License.txt in the project root for license information.
  *--------------------------------------------------------------------------------------------*/
-
+//@ts-check
 const cp = require('child_process');
 const fs = require('fs');
 const path = require('path');
diff --git a/build/npm/update-distro.js b/build/npm/update-distro.js
@@ -2,7 +2,7 @@
  *  Copyright (c) Microsoft Corporation. All rights reserved.
  *  Licensed under the MIT License. See License.txt in the project root for license information.
  *--------------------------------------------------------------------------------------------*/
-
+//@ts-check
 const cp = require('child_process');
 const path = require('path');
 const fs = require('fs');
@@ -15,4 +15,4 @@ const packageJsonPath = path.join(vscodePath, 'package.json');
 const packageJson = JSON.parse(fs.readFileSync(packageJsonPath, 'utf8'));
 
 packageJson.distro = commit;
-fs.writeFileSync(packageJsonPath, JSON.stringify(packageJson, null, 2));
+fs.writeFileSync(packageJsonPath, JSON.stringify(packageJson, null, 2));
diff --git a/build/npm/update-localization-extension.js b/build/npm/update-localization-extension.js
@@ -2,7 +2,7 @@
  *  Copyright (c) Microsoft Corporation. All rights reserved.
  *  Licensed under the MIT License. See License.txt in the project root for license information.
  *--------------------------------------------------------------------------------------------*/
-
+//@ts-check
 'use strict';
 
 let i18n = require("../lib/i18n");
