Skip to content

Commit c4b0d87

Browse files
jriekenjrieken
committed
https://github.com/microsoft/vscode/issues/103454
1 parent 591dd13 commit c4b0d87

5 files changed

Lines changed: 20 additions & 20 deletions

File tree

‎.vscode/searches/es6.code-search‎

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -5,21 +5,21 @@
55
10 results - 2 files
66

77
src/vs/base/browser/dom.ts:
8-
83 };
9-
84
10-
85: /** @deprecated ES6 - use classList*/
11-
86 export function hasClass(node: HTMLElement | SVGElement, className: string): boolean { return _classList.hasClass(node, className); }
12-
87: /** @deprecated ES6 - use classList*/
13-
88 export function addClass(node: HTMLElement | SVGElement, className: string): void { return _classList.addClass(node, className); }
14-
89: /** @deprecated ES6 - use classList*/
15-
90 export function addClasses(node: HTMLElement | SVGElement, ...classNames: string[]): void { return _classList.addClasses(node, ...classNames); }
16-
91: /** @deprecated ES6 - use classList*/
17-
92 export function removeClass(node: HTMLElement | SVGElement, className: string): void { return _classList.removeClass(node, className); }
18-
93: /** @deprecated ES6 - use classList*/
19-
94 export function removeClasses(node: HTMLElement | SVGElement, ...classNames: string[]): void { return _classList.removeClasses(node, ...classNames); }
20-
95: /** @deprecated ES6 - use classList*/
21-
96 export function toggleClass(node: HTMLElement | SVGElement, className: string, shouldHaveIt?: boolean): void { return _classList.toggleClass(node, className, shouldHaveIt); }
22-
97
8+
74 };
9+
75
10+
76: /** @deprecated ES6 - use classList*/
11+
77 export function hasClass(node: HTMLElement | SVGElement, className: string): boolean { return _classList.hasClass(node, className); }
12+
78: /** @deprecated ES6 - use classList*/
13+
79 export function addClass(node: HTMLElement | SVGElement, className: string): void { return _classList.addClass(node, className); }
14+
80: /** @deprecated ES6 - use classList*/
15+
81 export function addClasses(node: HTMLElement | SVGElement, ...classNames: string[]): void { return _classList.addClasses(node, ...classNames); }
16+
82: /** @deprecated ES6 - use classList*/
17+
83 export function removeClass(node: HTMLElement | SVGElement, className: string): void { return _classList.removeClass(node, className); }
18+
84: /** @deprecated ES6 - use classList*/
19+
85 export function removeClasses(node: HTMLElement | SVGElement, ...classNames: string[]): void { return _classList.removeClasses(node, ...classNames); }
20+
86: /** @deprecated ES6 - use classList*/
21+
87 export function toggleClass(node: HTMLElement | SVGElement, className: string, shouldHaveIt?: boolean): void { return _classList.toggleClass(node, className, shouldHaveIt); }
22+
88
2323

2424
src/vs/base/common/strings.ts:
2525
15

‎src/vs/base/browser/ui/breadcrumbs/breadcrumbsWidget.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -336,7 +336,7 @@ export class BreadcrumbsWidget {
336336
item.render(container);
337337
container.tabIndex = -1;
338338
container.setAttribute('role', 'listitem');
339-
dom.addClasses(container, 'monaco-breadcrumb-item');
339+
container.classList.add('monaco-breadcrumb-item');
340340
const iconContainer = dom.$(breadcrumbSeparatorIcon.cssSelector);
341341
container.appendChild(iconContainer);
342342
}

‎src/vs/editor/common/modes.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -358,7 +358,7 @@ export const completionKindToCssClass = (function () {
358358
data[CompletionItemKind.User] = 'account';
359359
data[CompletionItemKind.Issue] = 'issues';
360360

361-
return function (kind: CompletionItemKind) {
361+
return function (kind: CompletionItemKind): string {
362362
const name = data[kind];
363363
let codicon = name && iconRegistry.get(name);
364364
if (!codicon) {

‎src/vs/editor/contrib/documentSymbols/outlineTree.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -149,7 +149,7 @@ export class OutlineElementRenderer implements ITreeRenderer<OutlineElement, Fuz
149149
if (this._configurationService.getValue(OutlineConfigKeys.icons)) {
150150
// add styles for the icons
151151
template.iconClass.className = '';
152-
dom.addClasses(template.iconClass, `outline-element-icon ${SymbolKinds.toCssClassName(element.symbol.kind, true)}`);
152+
template.iconClass.classList.add(`outline-element-icon`, ...SymbolKinds.toCssClassName(element.symbol.kind, true).split(' '));
153153
}
154154
if (element.symbol.tags.indexOf(SymbolTag.Deprecated) >= 0) {
155155
options.extraClasses.push(`deprecated`);

‎src/vs/editor/contrib/suggest/suggestWidget.ts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ import * as strings from 'vs/base/common/strings';
1313
import { Event, Emitter } from 'vs/base/common/event';
1414
import { onUnexpectedError } from 'vs/base/common/errors';
1515
import { IDisposable, dispose, toDisposable, DisposableStore, Disposable } from 'vs/base/common/lifecycle';
16-
import { append, $, hide, show, getDomNodePagePosition, addDisposableListener, addStandardDisposableListener, addClasses } from 'vs/base/browser/dom';
16+
import { append, $, hide, show, getDomNodePagePosition, addDisposableListener, addStandardDisposableListener } from 'vs/base/browser/dom';
1717
import { IListVirtualDelegate, IListEvent, IListRenderer, IListMouseEvent, IListGestureEvent } from 'vs/base/browser/ui/list/list';
1818
import { List } from 'vs/base/browser/ui/list/listWidget';
1919
import { DomScrollableElement } from 'vs/base/browser/ui/scrollbar/scrollableElement';
@@ -233,7 +233,7 @@ class ItemRenderer implements IListRenderer<CompletionItem, ISuggestionTemplateD
233233
// normal icon
234234
data.icon.className = 'icon hide';
235235
data.iconContainer.className = '';
236-
addClasses(data.iconContainer, `suggest-icon ${completionKindToCssClass(suggestion.kind)}`);
236+
data.iconContainer.classList.add('suggest-icon', ...completionKindToCssClass(suggestion.kind).split(' '));
237237
}
238238

239239
if (suggestion.tags && suggestion.tags.indexOf(CompletionItemTag.Deprecated) >= 0) {

0 commit comments

Comments
 (0)