Better name for method

mjbvz · mjbvz · commit 974442023a6e · 2021-12-06T16:38:47.000-08:00
diff --git a/src/vs/workbench/contrib/webview/browser/webviewElement.ts b/src/vs/workbench/contrib/webview/browser/webviewElement.ts
@@ -810,7 +810,7 @@ export class WebviewElement extends Disposable implements IWebview, WebviewFindD
 		this._send('find', { value, previous });
 	}
 
-	public startFind(value: string) {
+	public updateFind(value: string) {
 		if (!value || !this.element) {
 			return;
 		}
diff --git a/src/vs/workbench/contrib/webview/browser/webviewFindWidget.ts b/src/vs/workbench/contrib/webview/browser/webviewFindWidget.ts
@@ -14,13 +14,14 @@ export interface WebviewFindDelegate {
 	readonly onDidStopFind: Event<void>;
 	readonly checkImeCompletionState: boolean;
 	find(value: string, previous: boolean): void;
-	startFind(value: string): void;
+	updateFind(value: string): void;
 	stopFind(keepSelection?: boolean): void;
 	focus(): void;
 }
 
 export class WebviewFindWidget extends SimpleFindWidget {
-	protected _findWidgetFocused: IContextKey<boolean>;
+
+	protected readonly _findWidgetFocused: IContextKey<boolean>;
 
 	constructor(
 		private readonly _delegate: WebviewFindDelegate,
@@ -53,10 +54,10 @@ export class WebviewFindWidget extends SimpleFindWidget {
 		this._delegate.focus();
 	}
 
-	public _onInputChanged(): boolean {
+	protected _onInputChanged(): boolean {
 		const val = this.inputValue;
 		if (val) {
-			this._delegate.startFind(val);
+			this._delegate.updateFind(val);
 		} else {
 			this._delegate.stopFind(false);
 		}
diff --git a/src/vs/workbench/contrib/webview/electron-sandbox/webviewElement.ts b/src/vs/workbench/contrib/webview/electron-sandbox/webviewElement.ts
@@ -107,15 +107,15 @@ export class ElectronWebviewElement extends WebviewElement {
 		}
 
 		if (!this._findStarted) {
-			this.startFind(value);
+			this.updateFind(value);
 		} else {
 			// continuing the find, so set findNext to false
 			const options: FindInFrameOptions = { forward: !previous, findNext: false, matchCase: false };
 			this._webviewMainService.findInFrame({ windowId: this.nativeHostService.windowId }, this.id, value, options);
 		}
 	}
 
-	public override startFind(value: string) {
+	public override updateFind(value: string) {
 		if (!value || !this.element) {
 			return;
 		}

Original file line number	Diff line number	Diff line change
`@@ -810,7 +810,7 @@ export class WebviewElement extends Disposable implements IWebview, WebviewFindD`
`810`	`810`	`this._send('find', { value, previous });`
`811`	`811`	`}`
`812`	`812`
`813`		`- public startFind(value: string) {`
	`813`	`+ public updateFind(value: string) {`
`814`	`814`	`if (!value \|\| !this.element) {`
`815`	`815`	`return;`
`816`	`816`	`}`
Original file line number	Diff line number	Diff line change
`@@ -107,15 +107,15 @@ export class ElectronWebviewElement extends WebviewElement {`
`107`	`107`	`}`
`108`	`108`
`109`	`109`	`if (!this._findStarted) {`
`110`		`- this.startFind(value);`
	`110`	`+ this.updateFind(value);`
`111`	`111`	`} else {`
`112`	`112`	`// continuing the find, so set findNext to false`
`113`	`113`	`const options: FindInFrameOptions = { forward: !previous, findNext: false, matchCase: false };`
`114`	`114`	`this._webviewMainService.findInFrame({ windowId: this.nativeHostService.windowId }, this.id, value, options);`
`115`	`115`	`}`
`116`	`116`	`}`
`117`	`117`
`118`		`- public override startFind(value: string) {`
	`118`	`+ public override updateFind(value: string) {`
`119`	`119`	`if (!value \|\| !this.element) {`
`120`	`120`	`return;`
`121`	`121`	`}`