Improve error message when a module cannot be bundled and exclude vs/nls from bundles (microsoft#152188)

alexdima · web-flow · commit 5e7d488b7c3f · 2022-06-15T12:51:27.000Z
diff --git a/build/gulpfile.editor.js b/build/gulpfile.editor.js
@@ -34,6 +34,7 @@ const editorEntryPoints = [
 	{
 		name: 'vs/base/common/worker/simpleWorker',
 		include: ['vs/editor/common/services/editorSimpleWorker'],
+		exclude: ['vs/nls'],
 		prepend: ['vs/loader.js'],
 		append: ['vs/base/worker/workerMain'],
 		dest: 'vs/base/worker/workerMain.js'
diff --git a/build/lib/bundle.js b/build/lib/bundle.js
@@ -298,9 +298,18 @@ function emitEntryPoint(modulesMap, deps, entryPoint, includedModules, prepend,
         if (module.shim) {
             mainResult.sources.push(emitShimmedModule(c, deps[c], module.shim, module.path, contents));
         }
-        else {
+        else if (module.defineLocation) {
             mainResult.sources.push(emitNamedModule(c, module.defineLocation, module.path, contents));
         }
+        else {
+            const moduleCopy = {
+                id: module.id,
+                path: module.path,
+                defineLocation: module.defineLocation,
+                dependencies: module.dependencies
+            };
+            throw new Error(`Cannot bundle module '${module.id}' for entry point '${entryPoint}' because it has no shim and it lacks a defineLocation: ${JSON.stringify(moduleCopy)}`);
+        }
     });
     Object.keys(usedPlugins).forEach((pluginName) => {
         const plugin = usedPlugins[pluginName];
diff --git a/build/lib/bundle.ts b/build/lib/bundle.ts
@@ -15,7 +15,7 @@ interface IPosition {
 interface IBuildModuleInfo {
 	id: string;
 	path: string;
-	defineLocation: IPosition;
+	defineLocation: IPosition | null;
 	dependencies: string[];
 	shim: string;
 	exports: any;
@@ -444,8 +444,16 @@ function emitEntryPoint(
 
 		if (module.shim) {
 			mainResult.sources.push(emitShimmedModule(c, deps[c], module.shim, module.path, contents));
-		} else {
+		} else if (module.defineLocation) {
 			mainResult.sources.push(emitNamedModule(c, module.defineLocation, module.path, contents));
+		} else {
+			const moduleCopy = {
+				id: module.id,
+				path: module.path,
+				defineLocation: module.defineLocation,
+				dependencies: module.dependencies
+			};
+			throw new Error(`Cannot bundle module '${module.id}' for entry point '${entryPoint}' because it has no shim and it lacks a defineLocation: ${JSON.stringify(moduleCopy)}`);
 		}
 	});
 
diff --git a/src/buildfile.js b/src/buildfile.js
@@ -32,12 +32,14 @@ exports.base = [
 	{
 		name: 'vs/editor/common/services/editorSimpleWorker',
 		include: ['vs/base/common/worker/simpleWorker'],
+		exclude: ['vs/nls'],
 		prepend: ['vs/loader.js', 'vs/nls.js'],
 		append: ['vs/base/worker/workerMain'],
 		dest: 'vs/base/worker/workerMain.js'
 	},
 	{
 		name: 'vs/base/common/worker/simpleWorker',
+		exclude: ['vs/nls'],
 	}
 ];
 

Original file line number	Diff line number	Diff line change
`@@ -34,6 +34,7 @@ const editorEntryPoints = [`
`34`	`34`	`{`
`35`	`35`	`name: 'vs/base/common/worker/simpleWorker',`
`36`	`36`	`include: ['vs/editor/common/services/editorSimpleWorker'],`
	`37`	`+ exclude: ['vs/nls'],`
`37`	`38`	`prepend: ['vs/loader.js'],`
`38`	`39`	`append: ['vs/base/worker/workerMain'],`
`39`	`40`	`dest: 'vs/base/worker/workerMain.js'`
Original file line number	Diff line number	Diff line change
`@@ -32,12 +32,14 @@ exports.base = [`
`32`	`32`	`{`
`33`	`33`	`name: 'vs/editor/common/services/editorSimpleWorker',`
`34`	`34`	`include: ['vs/base/common/worker/simpleWorker'],`
	`35`	`+ exclude: ['vs/nls'],`
`35`	`36`	`prepend: ['vs/loader.js', 'vs/nls.js'],`
`36`	`37`	`append: ['vs/base/worker/workerMain'],`
`37`	`38`	`dest: 'vs/base/worker/workerMain.js'`
`38`	`39`	`},`
`39`	`40`	`{`
`40`	`41`	`name: 'vs/base/common/worker/simpleWorker',`
	`42`	`+ exclude: ['vs/nls'],`
`41`	`43`	`}`
`42`	`44`	`];`
`43`	`45`