Remove empty logging from telemetry2 searches.

Jackson Kearl · Jackson Kearl · commit 2ce17a576c27 · 2020-01-27T16:26:10.000-08:00
diff --git a/.vscode/searches/ts36031.code-search b/.vscode/searches/ts36031.code-search
@@ -1,7 +1,6 @@
 # Query: \\w+\\?\\..+![(.[]
 # Flags: RegExp
 # ContextLines: 2
-
 src/vs/base/browser/ui/tree/asyncDataTree.ts:
   270  			} : undefined,
   271  			isChecked: options.ariaProvider!.isChecked ? (e) => {
diff --git a/src/vs/workbench/contrib/search/browser/searchEditorActions.ts b/src/vs/workbench/contrib/search/browser/searchEditorActions.ts
@@ -46,7 +46,7 @@ export const openNewSearchEditor =
 			}
 		}
 
-		telemetryService.publicLog2<{}, {}>('searchEditor/openNewSearchEditor');
+		telemetryService.publicLog2('searchEditor/openNewSearchEditor');
 
 		const input = instantiationService.invokeFunction(getOrMakeSearchEditorInput, { config: { query: selected } });
 		await editorService.openEditor(input, { pinned: true });
@@ -65,7 +65,7 @@ export const createEditorFromSearchResult =
 		const labelService = accessor.get(ILabelService);
 
 
-		telemetryService.publicLog2<{}, {}>('searchEditor/createEditorFromSearchResult');
+		telemetryService.publicLog2('searchEditor/createEditorFromSearchResult');
 
 		const labelFormatter = (uri: URI): string => labelService.getUriLabel(uri, { relative: true });
 
diff --git a/src/vs/workbench/contrib/search/browser/searchEditorInput.ts b/src/vs/workbench/contrib/search/browser/searchEditorInput.ts
@@ -118,7 +118,7 @@ export class SearchEditorInput extends EditorInput {
 	async saveAs(group: GroupIdentifier, options?: ITextFileSaveOptions): Promise<IEditorInput | undefined> {
 		const path = await this.fileDialogService.pickFileToSave(await this.suggestFileName(), options?.availableFileSystems);
 		if (path) {
-			this.telemetryService.publicLog2<{}, {}>('searchEditor/saveSearchResults');
+			this.telemetryService.publicLog2('searchEditor/saveSearchResults');
 			if (await this.textFileService.saveAs(this.resource, path, options)) {
 				this.setDirty(false);
 				if (!isEqual(path, this.resource)) {
@@ -266,7 +266,7 @@ export class SearchEditorContribution implements IWorkbenchContribution {
 				return undefined;
 			}
 
-			this.telemetryService.publicLog2<{}, {}>('searchEditor/openSavedSearchEditor');
+			this.telemetryService.publicLog2('searchEditor/openSavedSearchEditor');
 			const input = instantiationService.invokeFunction(getOrMakeSearchEditorInput, { uri: resource });
 			const opened = editorService.openEditor(input, { ...options, pinned: resource.scheme === searchEditorScheme, ignoreOverrides: true }, group);
 			return { override: Promise.resolve(opened) };

Original file line number	Diff line number	Diff line change
`@@ -46,7 +46,7 @@ export const openNewSearchEditor =`
`46`	`46`	`}`
`47`	`47`	`}`
`48`	`48`
`49`		`- telemetryService.publicLog2<{}, {}>('searchEditor/openNewSearchEditor');`
	`49`	`+ telemetryService.publicLog2('searchEditor/openNewSearchEditor');`
`50`	`50`
`51`	`51`	`const input = instantiationService.invokeFunction(getOrMakeSearchEditorInput, { config: { query: selected } });`
`52`	`52`	`await editorService.openEditor(input, { pinned: true });`
`@@ -65,7 +65,7 @@ export const createEditorFromSearchResult =`
`65`	`65`	`const labelService = accessor.get(ILabelService);`
`66`	`66`
`67`	`67`
`68`		`- telemetryService.publicLog2<{}, {}>('searchEditor/createEditorFromSearchResult');`
	`68`	`+ telemetryService.publicLog2('searchEditor/createEditorFromSearchResult');`
`69`	`69`
`70`	`70`	`const labelFormatter = (uri: URI): string => labelService.getUriLabel(uri, { relative: true });`
`71`	`71`