clean up @no_device_farm tags on ui tests#73393
Open
davidsbailey wants to merge 7 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During the initial migration from Sauce Labs to AWS Device Farm, we added the
@device_farmtag to a few ui tests. Now that our ui tests have stabilized a bit, I'd like to try re-enabling these two, which are currently skipped in every configuration that we ever run in DTT or drone. For a cheat sheet on what runs where, see: https://github.com/code-dot-org/code-dot-org/blob/staging/dashboard/test/ui/README.md#cicd-testingTesting story
mix_move_ai.featureui test consistently failed in chromedriver, then passed on the first retry in Device Farm (we allow up to 2 retries). this pattern is not currently considered to be a blocking issue, and there are ~10 other tests which behave similarly.teacher_student_toggle.featureeyes test passed 5x on the first run against local chromedriver. for good measure, I ran an additional drone run with[skip local webdriver]to force it to run in Device Farm, which is where it will run during the DTT.Deployment notes
Follow-up work
@skipto make it clearer that these tests are being skipped in all current run configurations, rather than silently using a combination of tags that effectively skips the feature.