fix a bug for failed query

mrtazz · mrtazz · commit 2eaf08d5ce36 · 2016-01-18T21:38:23.000-05:00
this would previously always set the ret.code to the curl response code, even
if the query failed. Maybe we want to switch to that in the future, but for
now we return -1 for invalid queries still.
diff --git a/source/connection.cc b/source/connection.cc
@@ -127,10 +127,11 @@ RestClient::Connection::performCurlRequest(const std::string& uri) {
 
     ret.body = "Failed to query.";
     ret.code = -1;
+  } else {
+    int64_t http_code = 0;
+    curl_easy_getinfo(this->curlHandle, CURLINFO_RESPONSE_CODE, &http_code);
+    ret.code = static_cast<int>(http_code);
   }
-  int64_t http_code = 0;
-  curl_easy_getinfo(this->curlHandle, CURLINFO_RESPONSE_CODE, &http_code);
-  ret.code = static_cast<int>(http_code);
 
   // TODO(mrtazz): get metrics from curl handle
   // free header list
