Added permissions for content slider

mgesing · mgesing · commit c7c52aba29ec · 2019-12-12T15:46:05.000+01:00
diff --git a/src/Libraries/SmartStore.Data/Migrations/201912111821362_AddNewPermissions.cs b/src/Libraries/SmartStore.Data/Migrations/201912111821362_AddNewPermissions.cs
@@ -22,19 +22,26 @@ public override void Down()
 
         public void Seed(SmartObjectContext context)
         {
-            var adminRole = context.Set<CustomerRole>().FirstOrDefault(x => x.SystemName == "Administrators");
+            var allRoles = context.Set<CustomerRole>().ToList();
+            var adminRole = allRoles.FirstOrDefault(x => x.SystemName == SystemCustomerRoleNames.Administrators);
             var migrator = new PermissionMigrator(context);
 
             var pluginDescriptors = PluginFinder.Current.GetPluginDescriptors();
             var installedPlugins = pluginDescriptors.Select(x => x.SystemName).ToList();
 
-            // TODO: more plugins to come...
             var pluginTypeNames = new Dictionary<string, string>
             {
                 { "SmartStore.DevTools", "SmartStore.DevTools.Security.DevToolsPermissions, SmartStore.DevTools" },
                 { "SmartStore.OutputCache", "SmartStore.OutputCache.Security.OutputCachePermissions, SmartStore.OutputCache" },
+                { "SmartStore.ContentSlider", "SmartStore.ContentSlider.Security.ContentSliderPermissions, SmartStore.ContentSlider" }
             };
 
+            // Special cases.
+            var displayPublicPermissions = new string[] { "contentslider.displayslider" };
+            var displayPublicRoles = allRoles
+                .Where(x => x.SystemName == SystemCustomerRoleNames.ForumModerators || x.SystemName == SystemCustomerRoleNames.Guests || x.SystemName == SystemCustomerRoleNames.Registered)
+                .ToArray();
+
             foreach (var pluginTypeName in pluginTypeNames)
             {
                 // Add permissions only for installed plugins.
@@ -49,6 +56,16 @@ public void Seed(SmartObjectContext context)
                         {
                             // Allow root permission for admin.
                             migrator.Allow(rootPermission, true, adminRole);
+
+                            // Handle special cases.
+                            foreach (var name in displayPublicPermissions)
+                            {
+                                var displayPublicPermission = newPermissions.FirstOrDefault(x => x.SystemName == name);
+                                if (displayPublicPermission != null)
+                                {
+                                    migrator.Allow(displayPublicPermission, true, displayPublicRoles);
+                                }
+                            }
                         }
                     }
                 }
diff --git a/src/Plugins/SmartStore.DevTools/Security/DevToolsPermissionProvider.cs b/src/Plugins/SmartStore.DevTools/Security/DevToolsPermissionProvider.cs
@@ -7,7 +7,7 @@
 namespace SmartStore.DevTools.Security
 {
     /// <summary>
-    /// All permissions provided by this plugin.
+    /// All permissions provided by this plugin. Recommended to use singular for names, <see cref="Permissions"/>.
     /// "devtools" is the root permission (by convention, doesn't contain any dot). Localization key is "Plugins.Permissions.DisplayName.DevTools".
     /// "devtools.read" and "devtools.update" do not need localization because they are contained in core, <see cref="PermissionService._displayNameResourceKeys"/>.
     /// </summary>

Original file line number	Diff line number	Diff line change
`@@ -7,7 +7,7 @@`
`7`	`7`	`namespace SmartStore.DevTools.Security`
`8`	`8`	`{`
`9`	`9`	`/// <summary>`
`10`		`- /// All permissions provided by this plugin.`
	`10`	`+ /// All permissions provided by this plugin. Recommended to use singular for names, <see cref="Permissions"/>.`
`11`	`11`	`/// "devtools" is the root permission (by convention, doesn't contain any dot). Localization key is "Plugins.Permissions.DisplayName.DevTools".`
`12`	`12`	`/// "devtools.read" and "devtools.update" do not need localization because they are contained in core, <see cref="PermissionService._displayNameResourceKeys"/>.`
`13`	`13`	`/// </summary>`