Skip to content

Commit 338571d

Browse files
authored
Merge pull request #12 from cloudwego/update-ignore
chore: update gitignore & remove hard-code
2 parents 324c6e7 + 532aced commit 338571d

4 files changed

Lines changed: 16 additions & 14 deletions

File tree

.github/ISSUE_TEMPLATE/bug_report.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,9 +27,9 @@ A clear and concise description of what you expected to happen.
2727

2828
If applicable, add screenshots to help explain your problem.
2929

30-
**Kitex version:**
30+
**Version:**
3131

32-
Please provide the version of Kitex you are using.
32+
Please provide the version of {project_name} you are using.
3333

3434
**Environment:**
3535

.gitignore

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,13 @@
1414
# Dependency directories (remove the comment below to include it)
1515
# vendor/
1616

17+
# Go workspace file
18+
go.work
19+
go.work.sum
20+
21+
# env file
22+
.env
23+
1724
# the result of the go build
1825
output*
1926
output/*

.golangci.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@ run:
33
# include `vendor` `third_party` `testdata` `examples` `Godeps` `builtin`
44
skip-dirs-use-default: true
55
skip-dirs:
6-
- kitex_gen
76
skip-files:
87
- ".*\\.mock\\.go$"
98
# output configuration options

CONTRIBUTING.md

Lines changed: 7 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,17 @@
11
# How to Contribute
22

33
## Your First Pull Request
4-
We use github for our codebase. You can start by reading [How To Pull Request](https://docs.github.com/en/github/collaborating-with-issues-and-pull-requests/about-pull-requests).
4+
We use GitHub for our codebase. You can start by reading [How To Pull Request](https://docs.github.com/en/github/collaborating-with-issues-and-pull-requests/about-pull-requests).
55

66
## Branch Organization
77
We use [git-flow](https://nvie.com/posts/a-successful-git-branching-model/) as our branch organization, as known as [FDD](https://en.wikipedia.org/wiki/Feature-driven_development)
88

99
## Bugs
1010
### 1. How to Find Known Issues
11-
We are using [Github Issues](https://github.com/cloudwego/kitex/issues) for our public bugs. We keep a close eye on this and try to make it clear when we have an internal fix in progress. Before filing a new task, try to make sure your problem doesn’t already exist.
11+
We are using [Github Issues](https://github.com/cloudwego/{project_name}/issues) for our public bugs. We keep a close eye on this and try to make it clear when we have an internal fix in progress. Before filing a new task, try to make sure your problem doesn’t already exist.
1212

1313
### 2. Reporting New Issues
14-
Providing a reduced test code is a recommended way for reporting issues. Then can placed in:
14+
Providing a reduced test code is a recommended way for reporting issues. Then can place in:
1515
- Just in issues
1616
- [Golang Playground](https://play.golang.org/)
1717

@@ -23,9 +23,9 @@ Please do not report the safe disclosure of bugs to public issues. Contact us by
2323

2424
## Submit a Pull Request
2525
Before you submit your Pull Request (PR) consider the following guidelines:
26-
1. Search [GitHub](https://github.com/cloudwego/kitex/pulls) for an open or closed PR that relates to your submission. You don't want to duplicate existing efforts.
26+
1. Search [GitHub](https://github.com/cloudwego/{project_name}/pulls) for an open or closed PR that relates to your submission. You don't want to duplicate existing efforts.
2727
2. Be sure that an issue describes the problem you're fixing, or documents the design for the feature you'd like to add. Discussing the design upfront helps to ensure that we're ready to accept your work.
28-
3. [Fork](https://docs.github.com/en/github/getting-started-with-github/fork-a-repo) the cloudwego/kitex repo.
28+
3. [Fork](https://docs.github.com/en/github/getting-started-with-github/fork-a-repo) the cloudwego {project_name} repo.
2929
4. In your forked repository, make your changes in a new git branch:
3030
```
3131
git checkout -b my-fix-branch develop
@@ -38,18 +38,14 @@ Before you submit your Pull Request (PR) consider the following guidelines:
3838
```
3939
git push origin my-fix-branch
4040
```
41-
9. In GitHub, send a pull request to `kitex:develop`
41+
9. In GitHub, send a pull request to `{project_name}:develop`
4242
4343
## Contribution Prerequisites
4444
- Our development environment keeps up with [Go Official](https://golang.org/project/).
4545
- You need fully checking with lint tools before submit your pull request. [gofmt](https://golang.org/pkg/cmd/gofmt/) and [golangci-lint](https://github.com/golangci/golangci-lint)
46-
- You are familiar with [Github](https://github.com)
46+
- You are familiar with [GitHub](https://github.com)
4747
- Maybe you need familiar with [Actions](https://github.com/features/actions)(our default workflow tool).
4848
4949
## Code Style Guides
50-
Also see [Pingcap General advice](https://pingcap.github.io/style-guide/general.html).
51-
52-
Good resources:
5350
- [Effective Go](https://golang.org/doc/effective_go)
5451
- [Go Code Review Comments](https://github.com/golang/go/wiki/CodeReviewComments)
55-
- [Uber Go Style Guide](https://github.com/uber-go/guide/blob/master/style.md)

0 commit comments

Comments
 (0)