From e610f744f49c0b013899d968549bc457c541fc0a Mon Sep 17 00:00:00 2001 From: erezrokah Date: Mon, 19 Dec 2022 12:14:15 +0200 Subject: [PATCH] fix(destination): Rename `NewDestinationPlugin` to `NewPlugin` --- plugins/destination/plugin.go | 2 +- plugins/destination/plugin_test.go | 8 ++++---- serve/destination_test.go | 2 +- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/plugins/destination/plugin.go b/plugins/destination/plugin.go index 697be753f6..970ebf623a 100644 --- a/plugins/destination/plugin.go +++ b/plugins/destination/plugin.go @@ -46,7 +46,7 @@ type Plugin struct { const writeWorkers = 1 -func NewDestinationPlugin(name string, version string, newDestinationClient NewClientFunc) *Plugin { +func NewPlugin(name string, version string, newDestinationClient NewClientFunc) *Plugin { p := &Plugin{ name: name, version: version, diff --git a/plugins/destination/plugin_test.go b/plugins/destination/plugin_test.go index 219da4410c..7feba261f5 100644 --- a/plugins/destination/plugin_test.go +++ b/plugins/destination/plugin_test.go @@ -11,14 +11,14 @@ import ( ) func TestPlugin(t *testing.T) { - p := NewDestinationPlugin("test", "development", NewTestDestinationMemDBClient) + p := NewPlugin("test", "development", NewTestDestinationMemDBClient) PluginTestSuiteRunner(t, p, nil, TestSuiteTests{}) } func TestOnNewError(t *testing.T) { ctx := context.Background() - p := NewDestinationPlugin("test", "development", newTestDestinationMemDBClientErrOnNew) + p := NewPlugin("test", "development", newTestDestinationMemDBClientErrOnNew) err := p.Init(ctx, getTestLogger(t), specs.Destination{}) if err == nil { @@ -29,7 +29,7 @@ func TestOnNewError(t *testing.T) { func TestOnWriteError(t *testing.T) { ctx := context.Background() newClientFunc := getNewTestDestinationMemDBClient(withErrOnWrite()) - p := NewDestinationPlugin("test", "development", newClientFunc) + p := NewPlugin("test", "development", newClientFunc) if err := p.Init(ctx, getTestLogger(t), specs.Destination{}); err != nil { t.Fatal(err) } @@ -56,7 +56,7 @@ func TestOnWriteError(t *testing.T) { func TestOnWriteCtxCancelled(t *testing.T) { ctx := context.Background() newClientFunc := getNewTestDestinationMemDBClient(withBlockingWrite()) - p := NewDestinationPlugin("test", "development", newClientFunc) + p := NewPlugin("test", "development", newClientFunc) if err := p.Init(ctx, getTestLogger(t), specs.Destination{}); err != nil { t.Fatal(err) } diff --git a/serve/destination_test.go b/serve/destination_test.go index 23c1200215..3594d15632 100644 --- a/serve/destination_test.go +++ b/serve/destination_test.go @@ -24,7 +24,7 @@ func bufDestinationDialer(context.Context, string) (net.Conn, error) { } func TestDestination(t *testing.T) { - plugin := destination.NewDestinationPlugin("testDestinationPlugin", "development", destination.NewTestDestinationMemDBClient) + plugin := destination.NewPlugin("testDestinationPlugin", "development", destination.NewTestDestinationMemDBClient) s := &destinationServe{ plugin: plugin, }